-
Notifications
You must be signed in to change notification settings - Fork 5k
[Fix-17073]Fix DataSource/JDBC connection failure #17081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix issue: kyuubi ha connection apache#17073
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md) |
SbloodyS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
ruanwenjun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Awesome work, congrats on your first merged pull request! |



[Bug][DataSource] kyuubi ha connection #17073](#17073)
Purpose of the pull request
This Pull Request fixes a bug that fail JDBC connection to Hive, specifically due to an issue with the constructed JDBC URL, and aims to close #17073.
Brief change log
Modified the getJdbcUrl method to use a (;) instead of (?) to separate base URL from the connection parameters.

also updated its corresponding test case to pass this change i.e. testGetJdbcUrl() method in KyuubiDataSourceProcessorTest class

Verify this pull request
This pull request is already covered by existing tests, such as:
KyuubiDataSourceProcessorTest class
fix issue: kyuubi ha connection #17073
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md