Skip to content

Conversation

@tusaryan
Copy link
Contributor

@tusaryan tusaryan commented Mar 24, 2025

[Bug][DataSource] kyuubi ha connection #17073](#17073)

Purpose of the pull request

This Pull Request fixes a bug that fail JDBC connection to Hive, specifically due to an issue with the constructed JDBC URL, and aims to close #17073.

Brief change log

Modified the getJdbcUrl method to use a (;) instead of (?) to separate base URL from the connection parameters.
Screenshot 2025-03-25 at 12 40 14 AM

also updated its corresponding test case to pass this change i.e. testGetJdbcUrl() method in KyuubiDataSourceProcessorTest class
Screenshot 2025-03-25 at 1 18 08 AM

Verify this pull request

This pull request is already covered by existing tests, such as:
KyuubiDataSourceProcessorTest class

fix issue: kyuubi ha connection #17073

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

@tusaryan tusaryan requested a review from SbloodyS as a code owner March 24, 2025 19:42
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 24, 2025

@tusaryan tusaryan marked this pull request as draft March 24, 2025 19:55
@tusaryan tusaryan changed the title [Fix-16540][Task Plugin] Updated the TaskExecutionContext to pass OUT parameters to the next node #16933Update KyuubiDataSourceProcessor and KyuubiDataSourceProcessorTest [Fix-17073]Fix DataSource/JDBC connection failure Mar 24, 2025
@tusaryan tusaryan marked this pull request as ready for review March 24, 2025 19:58
@SbloodyS SbloodyS requested a review from ruanwenjun March 27, 2025 05:48
@SbloodyS SbloodyS added the first time contributor First-time contributor label Mar 27, 2025
@SbloodyS SbloodyS added this to the 3.3.0 milestone Mar 27, 2025
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SbloodyS SbloodyS added the bug Something isn't working label Mar 27, 2025
@SbloodyS SbloodyS merged commit eefb1fa into apache:dev Mar 27, 2025
70 of 71 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 27, 2025

Awesome work, congrats on your first merged pull request!

davidzollo pushed a commit to davidzollo/dolphinscheduler that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend bug Something isn't working first time contributor First-time contributor test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][DataSource] kyuubi ha connection

3 participants