Skip to content

Conversation

@SbloodyS
Copy link
Member

Purpose of the pull request

close #16801

Brief change log

poNqG2Y9zg3tRCw.png

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@SbloodyS SbloodyS added this to the 3.3.0 milestone Nov 15, 2024
@SbloodyS SbloodyS self-assigned this Nov 15, 2024
@github-actions github-actions bot added UI ui and front end related backend labels Nov 15, 2024
@SbloodyS SbloodyS requested a review from Gallardot November 15, 2024 06:27
@SbloodyS SbloodyS added the feature new feature label Nov 15, 2024
caishunfeng
caishunfeng previously approved these changes Nov 18, 2024
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
25.0% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SbloodyS SbloodyS requested a review from caishunfeng November 18, 2024 08:36
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@SbloodyS SbloodyS merged commit f3b5d1f into apache:dev Nov 18, 2024
66 of 67 checks passed
@SbloodyS SbloodyS deleted the feature_16801 branch November 18, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend feature new feature test UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][UI] Add copy path of resource file in task definition

3 participants