[Improvement-16574][Master] Move some task operations into ITaskExecutionRunnable #16575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
commented
Sep 3, 2024
Comment on lines
-37
to
-39
| if (!taskExecutionRunnable.isTaskInstanceInitialized()) { | ||
| taskExecutionRunnable.initializeTaskInstance(); | ||
| } |
Member
Author
There was a problem hiding this comment.
Since the task instance should already initialized here.
| @Builder.Default | ||
| private TaskDependType taskDependType = TaskDependType.TASK_POST; | ||
|
|
||
| private CommandType execType; |
Member
Author
There was a problem hiding this comment.
The command type should always be COMPLEMENT_DATA
| // So we need to initialize the task instance here. | ||
| // Otherwise, we cannot find the statemachine by task instance state. | ||
| if (!taskExecutionRunnable.isTaskInstanceInitialized()) { | ||
| taskExecutionRunnable.initializeTaskInstance(); |
Member
Author
There was a problem hiding this comment.
Use initializeFirstRunTaskInstance is more accurate.
ruanwenjun
force-pushed
the
dev_wenjun_polishCode
branch
from
5fec609 to
84f81b5
Compare
ruanwenjun
force-pushed
the
dev_wenjun_polishCode
branch
2 times, most recently
from
a0a5d3a to
c7b1e63
Compare
ruanwenjun
force-pushed
the
dev_wenjun_polishCode
branch
from
c7b1e63 to
895e6db
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #16574
Brief change log
Verify this pull request
Verify by Master IT
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md