[Improvement-16546][Master] Add repeatTriggerWorkflowInstance/triggerFromFailureTasks/triggerFromSuspendTasks in IWorkflowControlClient #16545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
changed the title
ruanwenjun
force-pushed
the
dev_wenjun_implementSubWorkflow
branch
from
d057d27 to
bd40b64
Compare
ruanwenjun
changed the title
ruanwenjun
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| protected abstract Command constructTriggerCommand(final TriggerRequest triggerRequest, | ||
| final WorkflowInstance workflowInstance); | ||
|
|
||
| protected abstract TriggerResponse onTriggerSuccess(final WorkflowInstance workflowInstance); |
Check notice
Code scanning / CodeQL
Useless parameter
Comment on lines
+43
to
+50
| return Command.builder() | ||
| .commandType(CommandType.START_FAILURE_TASK_PROCESS) | ||
| .processDefinitionCode(workflowInstance.getProcessDefinitionCode()) | ||
| .processDefinitionVersion(workflowInstance.getProcessDefinitionVersion()) | ||
| .processInstanceId(workflowInstance.getId()) | ||
| .executorId(workflowInstanceRecoverFailureTasksRequest.getUserId()) | ||
| .startTime(new Date()) | ||
| .updateTime(new Date()) |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
Comment on lines
+43
to
+49
| return Command.builder() | ||
| .commandType(CommandType.START_FAILURE_TASK_PROCESS) | ||
| .processDefinitionCode(workflowInstance.getProcessDefinitionCode()) | ||
| .processDefinitionVersion(workflowInstance.getProcessDefinitionVersion()) | ||
| .processInstanceId(workflowInstance.getId()) | ||
| .executorId(workflowInstanceRecoverFailureTasksRequest.getUserId()) | ||
| .startTime(new Date()) |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
Comment on lines
+43
to
+48
| return Command.builder() | ||
| .commandType(CommandType.START_FAILURE_TASK_PROCESS) | ||
| .processDefinitionCode(workflowInstance.getProcessDefinitionCode()) | ||
| .processDefinitionVersion(workflowInstance.getProcessDefinitionVersion()) | ||
| .processInstanceId(workflowInstance.getId()) | ||
| .executorId(workflowInstanceRecoverFailureTasksRequest.getUserId()) |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
Comment on lines
+43
to
+50
| return Command.builder() | ||
| .commandType(CommandType.RECOVER_SUSPENDED_PROCESS) | ||
| .processDefinitionCode(workflowInstance.getProcessDefinitionCode()) | ||
| .processDefinitionVersion(workflowInstance.getProcessDefinitionVersion()) | ||
| .processInstanceId(workflowInstance.getId()) | ||
| .executorId(workflowInstanceRecoverSuspendTasksRequest.getUserId()) | ||
| .startTime(new Date()) | ||
| .updateTime(new Date()) |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
Comment on lines
+43
to
+49
| return Command.builder() | ||
| .commandType(CommandType.RECOVER_SUSPENDED_PROCESS) | ||
| .processDefinitionCode(workflowInstance.getProcessDefinitionCode()) | ||
| .processDefinitionVersion(workflowInstance.getProcessDefinitionVersion()) | ||
| .processInstanceId(workflowInstance.getId()) | ||
| .executorId(workflowInstanceRecoverSuspendTasksRequest.getUserId()) | ||
| .startTime(new Date()) |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
Comment on lines
+43
to
+48
| return Command.builder() | ||
| .commandType(CommandType.RECOVER_SUSPENDED_PROCESS) | ||
| .processDefinitionCode(workflowInstance.getProcessDefinitionCode()) | ||
| .processDefinitionVersion(workflowInstance.getProcessDefinitionVersion()) | ||
| .processInstanceId(workflowInstance.getId()) | ||
| .executorId(workflowInstanceRecoverSuspendTasksRequest.getUserId()) |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
Comment on lines
+43
to
+50
| return Command.builder() | ||
| .commandType(CommandType.REPEAT_RUNNING) | ||
| .processInstanceId(workflowInstance.getId()) | ||
| .processDefinitionCode(workflowInstance.getProcessDefinitionCode()) | ||
| .processDefinitionVersion(workflowInstance.getProcessDefinitionVersion()) | ||
| .executorId(repeatRunningRequest.getUserId()) | ||
| .startTime(new Date()) | ||
| .updateTime(new Date()) |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
Comment on lines
+43
to
+49
| return Command.builder() | ||
| .commandType(CommandType.REPEAT_RUNNING) | ||
| .processInstanceId(workflowInstance.getId()) | ||
| .processDefinitionCode(workflowInstance.getProcessDefinitionCode()) | ||
| .processDefinitionVersion(workflowInstance.getProcessDefinitionVersion()) | ||
| .executorId(repeatRunningRequest.getUserId()) | ||
| .startTime(new Date()) |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
Comment on lines
+43
to
+48
| return Command.builder() | ||
| .commandType(CommandType.REPEAT_RUNNING) | ||
| .processInstanceId(workflowInstance.getId()) | ||
| .processDefinitionCode(workflowInstance.getProcessDefinitionCode()) | ||
| .processDefinitionVersion(workflowInstance.getProcessDefinitionVersion()) | ||
| .executorId(repeatRunningRequest.getUserId()) |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
ruanwenjun
force-pushed
the
dev_wenjun_implementSubWorkflow
branch
from
bd40b64 to
e52219f
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #16546
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md