Skip to content

[Improvement-16501][dolphinscheduler-api]typo in Status.java（#16501） #16504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SbloodyS merged 24 commits into from
Aug 23, 2024
Merged

[Improvement-16501][dolphinscheduler-api]typo in Status.java（#16501） #16504

SbloodyS merged 24 commits into from
Aug 23, 2024

Conversation

@lyyprean
Copy link
Contributor

@lyyprean lyyprean commented Aug 22, 2024 •
edited by SbloodyS
Loading

Purpose of the pull request

Correct a typo close #16501

Brief change log

Correct typo in Status.java

Verify this pull request

This pull request is code cleanup without any test coverage.

lyyprean added 24 commits March 25, 2021 15:05
@lyyprean
this expression which always evaluates "true"
37f23be
@lyyprean
Merge branch 'dev' of https://github.com/apache/incubator-dolphinsche…
687f38b 
…duler into dev
@lyyprean
Merge branch 'dev' of https://github.com/apache/incubator-dolphinsche…
55de29e 
…duler into dev
@lyyprean
delete unused variables
5e2a665
@lyyprean
LogClientService add AutoCloseable
2cafe6a
@lyyprean
reformat code
bc3d216
@lyyprean
reformat code
471ce7f
@lyyprean
reformat code
34f6fbb
@lyyprean
add log in ProcessService
5fa9c4b
@lyyprean
reformat code
242b3f4
@lyyprean
Merge branch 'dev' of https://github.com/apache/incubator-dolphinsche…
ecee993 
…duler into dev
@lyyprean
Optimize the code
eedc6a9
@lyyprean
Merge branch 'dev' of https://github.com/apache/incubator-dolphinsche…
897495b 
…duler into dev
@lyyprean
Optimize the code
4c1ad5d
@lyyprean
[improvement]modify all methods that refer to LogClientService in the…
7fa2197 
… code.
@lyyprean
resolve conflict
20bcccb
@lyyprean
Merge branch 'dev' of https://github.com/apache/incubator-dolphinsche…
f755867 
…duler into dev
@lyyprean
delete unused code
40d16d0
@lyyprean
Merge branch 'dev' of https://github.com/apache/incubator-dolphinsche…
01e5748 
…duler into dev
@lyyprean
[Improvement] Optimized close of IO
f0f8420
@lyyprean
pull code from upstream dev
13cc918
@lyyprean
Merge branch 'dev' of github.com:apache/dolphinscheduler into dev
1cae6d9
@lyyprean
[Fix-16501][dolphinscheduler-api]typo in Status.java（apache#16501）
922050c
@lyyprean
Merge branch 'dev' of github.com:apache/dolphinscheduler into dev
e62d557
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Gallardot Gallardot added this to the 3.3.0 milestone Aug 22, 2024
@Gallardot Gallardot added the improvement make more easy to user or prompt friendly label Aug 22, 2024
@SbloodyS SbloodyS added the first time contributor First-time contributor label Aug 23, 2024
SbloodyS
SbloodyS approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@SbloodyS SbloodyS merged commit c99de20 into apache:dev Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gallardot Gallardot Gallardot approved these changes

@SbloodyS SbloodyS SbloodyS approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

Assignees

@lyyprean lyyprean

Labels

3.3.0 backend first time contributor First-time contributor improvement make more easy to user or prompt friendly

Projects

None yet

Milestone

3.3.0-alpha

Development

Successfully merging this pull request may close these issues.

[Bug] [dolphinscheduler-api] Delete workflow prompt error

3 participants

@lyyprean @Gallardot @SbloodyS