[Improvement-16487][Master] Improve the dependent result for workflow dependency tasks #16488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shouwangyw
requested review from
SbloodyS,
caishunfeng and
ruanwenjun
as code owners
shouwangyw
changed the title
SbloodyS
changed the title
Member
|
Please follow the pull request using the correct title and description next time. |
SbloodyS
requested changes
Aug 20, 2024
...r-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/DependentExecute.java
Outdated
Show resolved
Hide resolved
...r-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/DependentExecute.java
Outdated
Show resolved
Hide resolved
ruanwenjun
reviewed
Aug 20, 2024
...r-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/DependentExecute.java
Outdated
Show resolved
Hide resolved
ruanwenjun
added
bug
SbloodyS
reviewed
Aug 22, 2024
...r-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/DependentExecute.java
Outdated
Show resolved
Hide resolved
SbloodyS
approved these changes
Aug 22, 2024
Member
SbloodyS
left a comment
SbloodyS
left a comment
There was a problem hiding this comment.
LGTM. Thanks for your contribution.
|
|
Awesome work, congrats on your first merged pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
This pull request improve the dependent result for workflow dependency tasks
fix #16487
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md