Skip to content

Conversation

@wangxj3
Copy link
Contributor

@wangxj3 wangxj3 commented Aug 6, 2024

Purpose of the pull request

fix #16421

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 6, 2024

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@SbloodyS SbloodyS added this to the 3.3.0 milestone Aug 6, 2024
@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Aug 6, 2024
@SbloodyS SbloodyS merged commit d2f857e into apache:dev Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend improvement make more easy to user or prompt friendly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement][Dataource] duplicate code

3 participants