Skip to content

Conversation

@ThomasTan2002
Copy link
Contributor

@ThomasTan2002 ThomasTan2002 commented Jul 25, 2024

Purpose of the pull request

close #16375

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@boring-cyborg
Copy link

boring-cyborg bot commented Jul 25, 2024

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a Chore. Please follow the pull request notice create an improvement or document issue and link to this PR.

@ThomasTan2002
Copy link
Contributor Author

ThomasTan2002 commented Jul 26, 2024

This is not a Chore. Please follow the pull request notice create an improvement or document issue and link to this PR.

OK

@ThomasTan2002 ThomasTan2002 changed the title [Chore] change front build command [Doc-16375] change front build command Jul 26, 2024
@SbloodyS SbloodyS added first time contributor First-time contributor improvement make more easy to user or prompt friendly labels Jul 26, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone Jul 26, 2024
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wangxj3 wangxj3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangxj3 wangxj3 merged commit 94774e7 into apache:dev Jul 26, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 26, 2024

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

document first time contributor First-time contributor improvement make more easy to user or prompt friendly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Doc][UI] The command to build the front in the document ran incorrectly

3 participants