Skip to content

[DSIP-57][Audit] Revert PR 14981 code #16370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SbloodyS merged 5 commits into from
Jul 26, 2024
Merged

[DSIP-57][Audit] Revert PR 14981 code #16370

SbloodyS merged 5 commits into from
Jul 26, 2024

Conversation

@SbloodyS
Copy link
Member

@SbloodyS SbloodyS commented Jul 25, 2024 •
edited
Loading

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@github-actions github-actions bot added UI ui and front end related backend test labels Jul 25, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone Jul 25, 2024
@SbloodyS SbloodyS added the DSIP label Jul 25, 2024
@caishunfeng
Copy link
Contributor

caishunfeng commented Jul 26, 2024

The pr #14981 add the alert event listener, I think it's not same with audit log.

This pr seems to revert it, right? Please correct me if I'm wrong.

Can add some brief change log pr description?

@SbloodyS
Copy link
Member Author

SbloodyS commented Jul 26, 2024

The pr #14981 add the alert event listener, I think it's not same with audit log.

This pr seems to revert it, right? Please correct me if I'm wrong.

Can add some brief change log pr description?

Yes. I've discuss it with @ruanwenjun . Since the current workflow state is refactored in #16327, will add a new workflow state listener after it's merged.

@SbloodyS SbloodyS mentioned this pull request Jul 26, 2024
Closed
2 tasks
@SbloodyS SbloodyS changed the title [DSIP-57][Audit] Refactor PR 14981 code [DSIP-57][Audit] Revert PR 14981 code Jul 26, 2024
caishunfeng
caishunfeng approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

ruanwenjun
ruanwenjun approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to revert some doc? I am not sure.

@SbloodyS
Copy link
Member Author

SbloodyS commented Jul 26, 2024

Do we need to revert some doc? I am not sure.

So far I have not found the relevant document...

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
23.5% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

@SbloodyS SbloodyS merged commit d9244ca into apache:dev Jul 26, 2024
@SbloodyS SbloodyS deleted the dsip_57 branch July 26, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caishunfeng caishunfeng caishunfeng approved these changes

@ruanwenjun ruanwenjun ruanwenjun approved these changes

@EricGao888 EricGao888 Awaiting requested review from EricGao888 EricGao888 is a code owner

@songjianet songjianet Awaiting requested review from songjianet songjianet is a code owner

@Amy0104 Amy0104 Awaiting requested review from Amy0104

Assignees

@SbloodyS SbloodyS

Labels

backend DSIP test UI ui and front end related

Projects

None yet

Milestone

3.3.0-alpha

Development

Successfully merging this pull request may close these issues.

3 participants

@SbloodyS @caishunfeng @ruanwenjun