Skip to content

Conversation

@Kinsonx
Copy link

@Kinsonx Kinsonx commented Jul 24, 2024

Purpose of the pull request

Related issue: #15448
Using Map to avoid traversing List repeatedly when set userName, defCount for each project

Brief change log

Verify this pull request

This pull request is already covered by existing tests, such as (org.apache.dolphinscheduler.api.controller.ProjectControllerTest#testQueryProjectListPaging).

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@boring-cyborg
Copy link

boring-cyborg bot commented Jul 24, 2024

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the pull request notice and link to the correct issue. @Kinsonx

@Kinsonx Kinsonx changed the title [Improvement-15448] Use Map to avoid traversing List repeatedly [Improvement-16341][api] Use Map to avoid traversing List repeatedly Jul 24, 2024
@Kinsonx Kinsonx changed the title [Improvement-16341][api] Use Map to avoid traversing List repeatedly [Improvement-15448][api] Use Map to avoid traversing List repeatedly Jul 24, 2024
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SbloodyS SbloodyS added this to the 3.3.0 milestone Jul 28, 2024
@SbloodyS SbloodyS added improvement make more easy to user or prompt friendly first time contributor First-time contributor labels Jul 28, 2024
@sonarqubecloud
Copy link

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng merged commit 666201d into apache:dev Jul 29, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 29, 2024

Awesome work, congrats on your first merged pull request!

@Kinsonx Kinsonx deleted the improvment_15448 branch July 31, 2024 06:26
ailiujiarui pushed a commit to ailiujiarui/dolphinscheduler that referenced this pull request Sep 2, 2024
Co-authored-by: 石巧生(11032293) <[email protected]>
Co-authored-by: xiangzihao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend first time contributor First-time contributor improvement make more easy to user or prompt friendly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants