-
Notifications
You must be signed in to change notification settings - Fork 5k
[Improvement-15448][api] Use Map to avoid traversing List repeatedly #16365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md) |
SbloodyS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the pull request notice and link to the correct issue. @Kinsonx
SbloodyS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
caishunfeng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Awesome work, congrats on your first merged pull request! |
Co-authored-by: 石巧生(11032293) <[email protected]> Co-authored-by: xiangzihao <[email protected]>



Purpose of the pull request
Related issue: #15448
Using Map to avoid traversing List repeatedly when set userName, defCount for each project
Brief change log
Verify this pull request
This pull request is already covered by existing tests, such as (org.apache.dolphinscheduler.api.controller.ProjectControllerTest#testQueryProjectListPaging).
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md