[DSIP-53] Suggest add process lineage parsing for dependent task #16288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SbloodyS
requested review from
Amy0104,
EricGao888,
Gallardot,
caishunfeng,
ruanwenjun,
songjianet and
zhuangchong
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ler-tools/src/main/java/org/apache/dolphinscheduler/tools/lineage/MigrateLineageService.java
Fixed
Show fixed
Hide fixed
| Map<String, Object> result = | ||
| workFlowLineageService.queryDownstreamDependentTasks(workFlowCode, taskCode); | ||
| return returnDataList(result); | ||
| public Result<Map<String, Object>> queryDependentTasks(@Parameter(hidden = true) @RequestAttribute(value = Constants.SESSION_USER) User loginUser, |
Check notice
Code scanning / CodeQL
Useless parameter
| @RequestParam(value = "processDefinitionCode", required = true) long processDefinitionCode, | ||
| @RequestParam(value = "taskCode", required = true) long taskCode) { | ||
| Result result = new Result(); | ||
| public Result<Map<String, Object>> verifyTaskCanDelete(@Parameter(hidden = true) @RequestAttribute(value = Constants.SESSION_USER) User loginUser, |
Check notice
Code scanning / CodeQL
Useless parameter
| workFlowName = ParameterUtils.handleEscapes(workFlowName); | ||
| List<WorkFlowLineage> workFlowLineages = | ||
| workFlowLineageService.queryWorkFlowLineageByName(projectCode, workFlowName); | ||
| public Result<List<WorkFlowRelationDetail>> queryWorkFlowLineageByName(@Parameter(hidden = true) @RequestAttribute(value = SESSION_USER) User loginUser, |
Check notice
Code scanning / CodeQL
Useless parameter
...pi/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessLineageServiceImpl.java
Fixed
Show fixed
Hide fixed
...src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
Fixed
Show fixed
Hide fixed
caishunfeng
reviewed
Jul 10, 2024
...uler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessDefinitionService.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
Show resolved
Hide resolved
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/ProcessLineage.java
Outdated
Show resolved
Hide resolved
...scheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ProcessLineageMapper.java
Outdated
Show resolved
Hide resolved
...duler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessLineageMapper.xml
Outdated
Show resolved
Hide resolved
...duler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessLineageMapper.xml
Outdated
Show resolved
Hide resolved
dolphinscheduler-dao/src/main/resources/sql/upgrade/3.3.0_schema/mysql/dolphinscheduler_ddl.sql
Outdated
Show resolved
Hide resolved
caishunfeng
reviewed
Jul 11, 2024
...src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
Outdated
Show resolved
Hide resolved
...inscheduler-common/src/main/java/org/apache/dolphinscheduler/common/constants/Constants.java
Outdated
Show resolved
Hide resolved
...scheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ProcessLineageMapper.java
Outdated
Show resolved
Hide resolved
dolphinscheduler-dao/src/main/resources/sql/upgrade/3.3.0_schema/mysql/dolphinscheduler_ddl.sql
Outdated
Show resolved
Hide resolved
caishunfeng
approved these changes
Jul 11, 2024
| if (dependentParameters != null) { | ||
| List<DependentTaskModel> dependTaskList = | ||
| dependentParameters.getDependence().getDependTaskList(); | ||
| if (!CollectionUtils.isEmpty(dependTaskList)) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (!CollectionUtils.isEmpty(dependTaskList)) { | |
| if (CollectionUtils.isNotEmpty(dependTaskList)) { | |
| return; | |
| } |
ruanwenjun
approved these changes
Jul 11, 2024
| */ | ||
|
|
||
| DROP TABLE IF EXISTS `t_ds_process_task_lineage`; | ||
| CREATE TABLE `t_ds_process_task_lineage` |
Member
There was a problem hiding this comment.
Suggested change
| CREATE TABLE `t_ds_process_task_lineage` | |
| CREATE TABLE `t_ds_workflow_task_lineage` |
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #16255
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md