Skip to content

[Feature-16132][Task Plugin] support for oceanbase datax task #16281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
caishunfeng merged 3 commits into from
Jul 16, 2024
Merged

[Feature-16132][Task Plugin] support for oceanbase datax task #16281

caishunfeng merged 3 commits into from
Jul 16, 2024

Conversation

@xxsc0529
Copy link
Contributor

@xxsc0529 xxsc0529 commented Jul 5, 2024 •
edited
Loading

Purpose of the pull request

Support for oceanbase datax task. Close #16132.

Brief change log

Add support for oceanbase datax task.

Verify this pull request

Tested locally, see the picture below.

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@xxsc0529 xxsc0529 closed this Jul 5, 2024
@github-actions github-actions bot added UI ui and front end related backend labels Jul 5, 2024
@xxsc0529 xxsc0529 reopened this Jul 5, 2024
@xxsc0529
Copy link
Contributor Author

xxsc0529 commented Jul 5, 2024 •
edited
Loading

image

SbloodyS
SbloodyS requested changes Jul 5, 2024
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please using english and follow the pull request notice

@xxsc0529 xxsc0529 closed this Jul 5, 2024
@xxsc0529
Copy link
Contributor Author

xxsc0529 commented Jul 5, 2024

Please using english and follow the pull request notice

It has been modified

@xxsc0529 xxsc0529 reopened this Jul 5, 2024
@SbloodyS SbloodyS changed the title [Feature-16280][Task Plugin] support for oceanbase datax task [Feature-16132][Task Plugin] support for oceanbase datax task Jul 5, 2024
@SbloodyS SbloodyS added the feature new feature label Jul 5, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone Jul 5, 2024
@SbloodyS SbloodyS added the first time contributor First-time contributor label Jul 5, 2024
@ruanwenjun
Copy link
Member

ruanwenjun commented Jul 10, 2024

Have you tested this, please provide the screen picture to make sure this can work.

@xxsc0529
Copy link
Contributor Author

xxsc0529 commented Jul 11, 2024

Have you tested this, please provide the screen picture to make sure this can work.

I have done tests. Please see the test process and attached execution log file below.
This is from mysql to oceanbase. The principles of other databases are the same. Here are the test records of mysql and oceanbase.
image
image
1720682402198.log
The following is the record from oceanbase to mysql.
image
image
1720683325319.log

@xxsc0529 xxsc0529 requested review from SbloodyS July 11, 2024 08:27
@xxsc0529 xxsc0529 closed this Jul 12, 2024
@xxsc0529 xxsc0529 reopened this Jul 12, 2024
ruanwenjun
ruanwenjun approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SbloodyS
SbloodyS approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

caishunfeng
caishunfeng approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng merged commit 1199a91 into apache:dev Jul 16, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 16, 2024

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caishunfeng caishunfeng caishunfeng approved these changes

@ruanwenjun ruanwenjun ruanwenjun approved these changes

@songjianet songjianet Awaiting requested review from songjianet songjianet is a code owner

@Amy0104 Amy0104 Awaiting requested review from Amy0104

@zhuangchong zhuangchong Awaiting requested review from zhuangchong

@Gallardot Gallardot Awaiting requested review from Gallardot Gallardot is a code owner

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

Assignees

@xxsc0529 xxsc0529

Labels

backend feature new feature first time contributor First-time contributor ready-to-merge UI ui and front end related

Projects

None yet

Milestone

3.3.0-alpha

Development

Successfully merging this pull request may close these issues.

[Feature][DataX] Support OceanBase datasource in DataX task

4 participants

@xxsc0529 @ruanwenjun @caishunfeng @SbloodyS