Skip to content

Conversation

@Gallardot
Copy link
Member

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@Gallardot Gallardot changed the title [Improvement][Metrics] add heartbeat metrics [Improvement-16266][Metrics] add heartbeat metrics Jul 3, 2024
@Gallardot Gallardot added this to the 3.3.0 milestone Jul 3, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
57.9% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Jul 3, 2024
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickchengx rickchengx merged commit 97d164c into apache:dev Jul 3, 2024
@Gallardot Gallardot deleted the hb branch July 3, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.3.0 backend improvement make more easy to user or prompt friendly metrics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement][Metrics] add heartbeat metrics

3 participants