Skip to content

Conversation

@SbloodyS
Copy link
Member

Purpose of the pull request

Brief change log

Add api-test and e2e-test to spotless check

@SbloodyS SbloodyS marked this pull request as draft June 30, 2024 02:32
@SbloodyS SbloodyS force-pushed the improve_spotless_check branch from 5e1a68d to e907716 Compare June 30, 2024 02:39
@SbloodyS SbloodyS added this to the 3.3.0 milestone Jun 30, 2024
@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Jun 30, 2024
@SbloodyS SbloodyS marked this pull request as ready for review June 30, 2024 02:41
@SbloodyS SbloodyS force-pushed the improve_spotless_check branch from e907716 to f1a2e41 Compare June 30, 2024 02:45
@SbloodyS SbloodyS marked this pull request as draft June 30, 2024 03:03
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.15%. Comparing base (177a001) to head (bcd7e2c).

Current head bcd7e2c differs from pull request most recent head e7cb96a

Please upload reports for the commit e7cb96a to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #16242      +/-   ##
============================================
+ Coverage     41.12%   41.15%   +0.03%     
- Complexity     5085     5090       +5     
============================================
  Files          1391     1391              
  Lines         43737    43803      +66     
  Branches       4633     4645      +12     
============================================
+ Hits          17987    18029      +42     
- Misses        23982    24008      +26     
+ Partials       1768     1766       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SbloodyS SbloodyS marked this pull request as ready for review June 30, 2024 05:23
@sonarqubecloud
Copy link

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit 565a917 into apache:dev Jun 30, 2024
@SbloodyS SbloodyS deleted the improve_spotless_check branch June 30, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI&CD e2e e2e test improvement make more easy to user or prompt friendly test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants