Skip to content

Conversation

@SbloodyS
Copy link
Member

Purpose of the pull request

close #16229

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@github-actions github-actions bot added UI ui and front end related backend test CI&CD e2e e2e test labels Jun 29, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone Jun 29, 2024
@SbloodyS SbloodyS added the feature new feature label Jun 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.15%. Comparing base (565a917) to head (a3920e8).
Report is 1 commits behind head on dev.

Current head a3920e8 differs from pull request most recent head f5839a4

Please upload reports for the commit f5839a4 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #16240      +/-   ##
============================================
- Coverage     41.17%   41.15%   -0.03%     
+ Complexity     5093     5090       -3     
============================================
  Files          1391     1391              
  Lines         43803    43803              
  Branches       4645     4645              
============================================
- Hits          18038    18029       -9     
- Misses        23997    24008      +11     
+ Partials       1768     1766       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SbloodyS SbloodyS marked this pull request as draft June 29, 2024 13:53
@SbloodyS SbloodyS marked this pull request as ready for review June 29, 2024 15:32
@SbloodyS SbloodyS requested a review from ruanwenjun June 29, 2024 15:33
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 1, 2024

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng merged commit 1fe8a6e into apache:dev Jul 1, 2024
@SbloodyS SbloodyS deleted the feature_16229 branch July 1, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend CI&CD e2e e2e test feature new feature test UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][E2E] Add python using file e2e test case

4 participants