Skip to content

Conversation

@ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Jun 27, 2024

Purpose of the pull request

close #16228

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun requested a review from SbloodyS as a code owner June 27, 2024 10:39
@github-actions github-actions bot added test e2e e2e test labels Jun 27, 2024
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixE2EHealthCheck branch from bcf3d65 to a17e3bd Compare June 27, 2024 10:44
@ruanwenjun ruanwenjun added this to the 3.3.0 milestone Jun 27, 2024
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixE2EHealthCheck branch from a17e3bd to e3519be Compare June 27, 2024 11:01
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixE2EHealthCheck branch from e3519be to 0e3b9d7 Compare June 27, 2024 11:28
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun added improvement make more easy to user or prompt friendly priority:high labels Jun 27, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.24%. Comparing base (46eff34) to head (ba7663f).

Current head ba7663f differs from pull request most recent head 0e3b9d7

Please upload reports for the commit 0e3b9d7 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #16227      +/-   ##
============================================
- Coverage     41.26%   41.24%   -0.02%     
+ Complexity     5122     5120       -2     
============================================
  Files          1397     1397              
  Lines         44055    44055              
  Branches       4666     4666              
============================================
- Hits          18178    18172       -6     
- Misses        24097    24102       +5     
- Partials       1780     1781       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarCloud

@ruanwenjun ruanwenjun changed the title Fix E2E health check url is not correct [Fix-16228] Fix E2E health check url is not correct Jun 27, 2024
@ruanwenjun ruanwenjun merged commit 0e2d0fb into apache:dev Jun 27, 2024
@ruanwenjun ruanwenjun deleted the dev_wenjun_fixE2EHealthCheck branch June 27, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend e2e e2e test improvement make more easy to user or prompt friendly priority:high test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] E2E health check url is incorrect

4 participants