Skip to content

Conversation

@ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Jun 19, 2024

Purpose of the pull request

close #16182

Brief change log

  • Set the connect timeout to 15s
  • Change the retry interval to 1s~3s

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

SbloodyS
SbloodyS previously approved these changes Jun 19, 2024
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SbloodyS SbloodyS added the 3.3.0 label Jun 19, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone Jun 19, 2024
@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Jun 19, 2024
@SbloodyS SbloodyS changed the title Increase zk connect timeout [Improvement] Increase zk connect timeout Jun 19, 2024
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixZkConnectTimeout branch 3 times, most recently from 5ec7ee4 to 3b784dd Compare June 19, 2024 09:07
@ruanwenjun ruanwenjun requested a review from SbloodyS June 19, 2024 09:55
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixZkConnectTimeout branch from 3b784dd to bf07a8d Compare June 19, 2024 09:55
SbloodyS
SbloodyS previously approved these changes Jun 19, 2024
@ruanwenjun ruanwenjun changed the title [Improvement] Increase zk connect timeout [Improvement-16182] Increase zk connect timeout Jun 19, 2024
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixZkConnectTimeout branch from bf07a8d to d390138 Compare June 19, 2024 10:51
@ruanwenjun ruanwenjun requested a review from SbloodyS June 19, 2024 13:49
@ruanwenjun ruanwenjun requested a review from rickchengx June 20, 2024 01:59
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixZkConnectTimeout branch from e96b42c to c18ec4a Compare June 20, 2024 02:09
@sonarqubecloud
Copy link

Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun deleted the dev_wenjun_fixZkConnectTimeout branch November 23, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.3.0 backend improvement make more easy to user or prompt friendly test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement] The default zk connect timeout is 600ms will cause connect failed

3 participants