Skip to content

Conversation

@caicancai
Copy link
Member

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@caicancai
Copy link
Member Author

cc @SbloodyS PATL, thanks

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SbloodyS SbloodyS added improvement make more easy to user or prompt friendly 3.3.0 labels Jun 16, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone Jun 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.70%. Comparing base (834c320) to head (86120ef).

Current head 86120ef differs from pull request most recent head 82b0789

Please upload reports for the commit 82b0789 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #16160      +/-   ##
============================================
- Coverage     40.71%   40.70%   -0.01%     
- Complexity     5246     5247       +1     
============================================
  Files          1385     1385              
  Lines         46109    46109              
  Branches       4923     4923              
============================================
- Hits          18771    18770       -1     
- Misses        25412    25414       +2     
+ Partials       1926     1925       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@SbloodyS SbloodyS merged commit 61a6bd0 into apache:dev Jun 17, 2024
@caicancai caicancai deleted the tcp branch June 17, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.3.0 backend improvement make more easy to user or prompt friendly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants