Skip to content

Conversation

@caicancai
Copy link
Member

@caicancai caicancai commented Jun 13, 2024

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@caicancai caicancai changed the title [Imporve][Master] Refine the doselect annotation of the distribution … [Imporve][Master] Refine the doselect annotation of the distributionpolicy Jun 13, 2024
@SbloodyS SbloodyS added improvement make more easy to user or prompt friendly 3.3.0 labels Jun 13, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone Jun 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.71%. Comparing base (8d0202c) to head (8793f2d).

Current head 8793f2d differs from pull request most recent head a897fa7

Please upload reports for the commit a897fa7 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #16149   +/-   ##
=========================================
  Coverage     40.70%   40.71%           
  Complexity     5246     5246           
=========================================
  Files          1385     1385           
  Lines         46109    46109           
  Branches       4923     4923           
=========================================
+ Hits          18769    18771    +2     
+ Misses        25414    25412    -2     
  Partials       1926     1926           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@caicancai
Copy link
Member Author

@SbloodyS @ruanwenjun Thank you for your review

@SbloodyS SbloodyS merged commit 834c320 into apache:dev Jun 14, 2024
@caicancai caicancai deleted the select_comment branch June 14, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.3.0 backend improvement make more easy to user or prompt friendly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants