[Improvement] Add RPC metrics #16121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...t-base/src/main/java/org/apache/dolphinscheduler/extract/base/client/NettyClientHandler.java
Fixed
Show fixed
Hide fixed
...e/src/main/java/org/apache/dolphinscheduler/extract/base/server/JdkDynamicServerHandler.java
Fixed
Show fixed
Hide fixed
SbloodyS
requested changes
Jun 6, 2024
...ract-base/src/test/java/org/apache/dolphinscheduler/extract/base/metrics/RpcMetricsTest.java
Outdated
Show resolved
Hide resolved
ruanwenjun
force-pushed
the
dev_wenjun_addRpcMetrics
branch
2 times, most recently
from
9a9742b to
ed03189
Compare
ruanwenjun
force-pushed
the
dev_wenjun_addRpcMetrics
branch
from
ed03189 to
6e3b139
Compare
ruanwenjun
force-pushed
the
dev_wenjun_addRpcMetrics
branch
from
6e3b139 to
2880f36
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #16121 +/- ##
============================================
+ Coverage 40.66% 40.70% +0.03%
- Complexity 5238 5245 +7
============================================
Files 1382 1385 +3
Lines 46026 46109 +83
Branches 4920 4923 +3
============================================
+ Hits 18718 18770 +52
- Misses 25384 25412 +28
- Partials 1924 1927 +3 ☔ View full report in Codecov by Sentry. |
ruanwenjun
force-pushed
the
dev_wenjun_addRpcMetrics
branch
from
516c2d3 to
7ef6c6c
Compare
|
SbloodyS
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #16119
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md