Skip to content

Conversation

@Gallardot
Copy link
Member

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SbloodyS SbloodyS added improvement make more easy to user or prompt friendly 3.3.0 labels Jun 1, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone Jun 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.67%. Comparing base (7ae9ca5) to head (b3156a9).

Current head b3156a9 differs from pull request most recent head dd51932

Please upload reports for the commit dd51932 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #16104      +/-   ##
============================================
- Coverage     40.68%   40.67%   -0.02%     
+ Complexity     5238     5237       -1     
============================================
  Files          1382     1382              
  Lines         46020    46020              
  Branches       4921     4921              
============================================
- Hits          18722    18717       -5     
- Misses        25374    25379       +5     
  Partials       1924     1924              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 1, 2024

@SbloodyS SbloodyS requested review from EricGao888 and Radeity June 4, 2024 03:34
@SbloodyS SbloodyS merged commit 4f6e715 into apache:dev Jun 4, 2024
@Gallardot Gallardot deleted the Gallardot-patch-1 branch June 4, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.3.0 backend improvement make more easy to user or prompt friendly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants