[DSIP-44] Set a delay time to TaskExecuteRunnable if it dispatched failed #16069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
requested review from
SbloodyS,
caishunfeng and
zhuangchong
as code owners
ruanwenjun
added
priority:middle
improvement
ruanwenjun
force-pushed
the
dev_wenjun_addDelayEntry
branch
from
f0852ce to
7ac4297
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ster/src/main/java/org/apache/dolphinscheduler/server/master/runner/TaskExecuteRunnable.java
Fixed
Show fixed
Hide fixed
...-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/queue/DelayEntry.java
Fixed
Show fixed
Hide fixed
ruanwenjun
force-pushed
the
dev_wenjun_addDelayEntry
branch
2 times, most recently
from
a4f5b4c to
ec0bef3
Compare
...-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/queue/DelayEntry.java
Fixed
Show fixed
Hide fixed
ruanwenjun
force-pushed
the
dev_wenjun_addDelayEntry
branch
from
ec0bef3 to
2269b21
Compare
Radeity
reviewed
May 25, 2024
.../src/main/java/org/apache/dolphinscheduler/server/master/runner/BaseTaskExecuteRunnable.java
Show resolved
Hide resolved
.../src/main/java/org/apache/dolphinscheduler/server/master/runner/BaseTaskExecuteRunnable.java
Show resolved
Hide resolved
...a/org/apache/dolphinscheduler/server/master/runner/GlobalTaskDispatchWaitingQueueLooper.java
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #16069 +/- ##
============================================
- Coverage 40.68% 40.67% -0.01%
- Complexity 5231 5242 +11
============================================
Files 1381 1382 +1
Lines 46010 46023 +13
Branches 4920 4921 +1
============================================
+ Hits 18718 18719 +1
- Misses 25366 25379 +13
+ Partials 1926 1925 -1 ☔ View full report in Codecov by Sentry. |
ruanwenjun
force-pushed
the
dev_wenjun_addDelayEntry
branch
from
c5baa75 to
be3d550
Compare
Member
Author
|
No new change, just rebase commit. |
Radeity
approved these changes
May 27, 2024
ruanwenjun
force-pushed
the
dev_wenjun_addDelayEntry
branch
from
be3d550 to
298e3da
Compare
EricGao888
approved these changes
May 27, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Fix GlobalTaskDispatchWaitingQueueLooper might be busy when worker is unavaliable
close #16065
Brief change
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md