[Improvement][Helm] Make configmap of api/master/worker/alert configuration #16058
Conversation
|
Then |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #16058 +/- ##
============================================
+ Coverage 40.70% 40.72% +0.01%
- Complexity 5245 5247 +2
============================================
Files 1385 1385
Lines 46109 46109
Branches 4923 4923
============================================
+ Hits 18768 18776 +8
+ Misses 25414 25407 -7
+ Partials 1927 1926 -1 ☔ View full report in Codecov by Sentry. |
|
Hi @pegasas , please fix CI. |
| # cpu: "500m" | ||
|
|
||
| enableCustomizedConfig: false | ||
| customizedConfig: { } |
There was a problem hiding this comment.
New configuration items need to be commented
There was a problem hiding this comment.
Add comments link to origin application.yaml path.
| {{ $path }}: | | ||
| {{ $config | indent 4 -}} | ||
| {{- end -}} | ||
| {{- end -}} |
There was a problem hiding this comment.
need a new line at the end of the file
pegasas
force-pushed
the
issues/16028
branch
3 times, most recently
from
7b33d3e to
9286014
Compare
|
Help check this? cc @Gallardot |
deploy/kubernetes/dolphinscheduler/templates/statefulset-dolphinscheduler-worker.yaml
Outdated
Show resolved
Hide resolved
…ration Update deploy/kubernetes/dolphinscheduler/templates/statefulset-dolphinscheduler-worker.yaml Co-authored-by: Gallardot <[email protected]>
Radeity
added
improvement
ruanwenjun
changed the title
Co-authored-by: Wenjun Ruan <[email protected]>
|
hi, team, would you like to review the PR when anytime you are available? Thanks |
rickchengx
left a comment
rickchengx
left a comment
There was a problem hiding this comment.
LGTM, this could avoid multiple application.yaml
|
1 similar comment
|
…ration (apache#16058) Update deploy/kubernetes/dolphinscheduler/templates/statefulset-dolphinscheduler-worker.yaml * Update deploy/kubernetes/dolphinscheduler/values.yaml
* [Fix-16174] Incorrect cluster installation guide. (#16208) * [Fix][CI] fix the ci error of Values.datasource.profile (#16031) * [Improvement][Helm] Make configmap of api/master/worker/alert configuration (#16058) Update deploy/kubernetes/dolphinscheduler/templates/statefulset-dolphinscheduler-worker.yaml * Update deploy/kubernetes/dolphinscheduler/values.yaml * [helm] remove appversion from labels (#16066)
7 participants
…ration
Purpose of the pull request
resolve: #16028
Brief change log
we found that it will bring multi application.yaml maintainence cost after involving new configmap into helm chart.
After discussion we decide to add a flag and default false,
then we can keep application.yaml in api/master/worker/alert clean.
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md