Skip to content

Conversation

@ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented May 16, 2024

Due to 2.0.9 and 3.0.6 is not a LTS version, we don't need to continue add upgrade test for this. We only need to focus on upgrade from 3.1.x to latest, since 3.1.x will not change the database schema anymore.

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.58%. Comparing base (79f90a8) to head (77d8022).
Report is 1 commits behind head on dev.

Current head 77d8022 differs from pull request most recent head 6c4c3db

Please upload reports for the commit 6c4c3db to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #16012   +/-   ##
=========================================
  Coverage     40.58%   40.58%           
  Complexity     5216     5216           
=========================================
  Files          1380     1380           
  Lines         46056    46056           
  Branches       4916     4916           
=========================================
  Hits          18693    18693           
  Misses        25437    25437           
  Partials       1926     1926           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SbloodyS
SbloodyS previously approved these changes May 16, 2024
EricGao888
EricGao888 previously approved these changes May 16, 2024
@ruanwenjun ruanwenjun marked this pull request as draft May 16, 2024 07:39
@ruanwenjun ruanwenjun dismissed stale reviews from EricGao888 and SbloodyS via 289194c May 16, 2024 07:42
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixPGSyncDev branch 5 times, most recently from b1d0731 to bf6456e Compare May 16, 2024 09:17
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixPGSyncDev branch 2 times, most recently from 97abf83 to 9ecbc87 Compare May 16, 2024 10:33
@github-actions github-actions bot added the CI&CD label May 16, 2024
@ruanwenjun ruanwenjun changed the title Fix PG database schema change incorrect 2.3.9 Deprecated 2.0.9/3.0.6 upgrade test May 16, 2024
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixPGSyncDev branch from 9ecbc87 to 7c21b58 Compare May 16, 2024 10:57
@ruanwenjun ruanwenjun marked this pull request as ready for review May 16, 2024 10:57
@ruanwenjun ruanwenjun self-assigned this May 16, 2024
@ruanwenjun ruanwenjun added improvement make more easy to user or prompt friendly 3.2.2 labels May 16, 2024
@ruanwenjun ruanwenjun added this to the 3.2.2 milestone May 16, 2024
@ruanwenjun ruanwenjun requested review from EricGao888 and SbloodyS May 16, 2024 10:58
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ruanwenjun
Copy link
Member Author

Are you four the same person? Why do you always appear at the same moment? 😄

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ruanwenjun ruanwenjun merged commit cb0b4fa into apache:dev May 17, 2024
@ruanwenjun ruanwenjun deleted the dev_wenjun_fixPGSyncDev branch May 17, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.2.2 backend CI&CD improvement make more easy to user or prompt friendly ready-to-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants