[Fix-15992] maintain slot index by iterate MasterPriorityQueue orderly #15993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SbloodyS
added
bug
ruanwenjun
requested changes
May 14, 2024
...ler-service/src/main/java/org/apache/dolphinscheduler/service/queue/MasterPriorityQueue.java
Outdated
Show resolved
Hide resolved
ruanwenjun
reviewed
May 14, 2024
...ler-service/src/main/java/org/apache/dolphinscheduler/service/queue/MasterPriorityQueue.java
Outdated
Show resolved
Hide resolved
...service/src/test/java/org/apache/dolphinscheduler/service/queue/MasterPriorityQueueTest.java
Outdated
Show resolved
Hide resolved
Member
|
Please fix the code style by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #15993 +/- ##
============================================
+ Coverage 39.91% 40.43% +0.52%
- Complexity 5083 5184 +101
============================================
Files 1370 1379 +9
Lines 45649 46093 +444
Branches 4869 4924 +55
============================================
+ Hits 18223 18640 +417
+ Misses 25527 25526 -1
- Partials 1899 1927 +28 ☔ View full report in Codecov by Sentry. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
fix #15992
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md