-
Notifications
You must be signed in to change notification settings - Fork 5k
[Improvement][Monitor] Show master && worker Busy Or Normal Status and Show Commands table list #15978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add monitor enhance ui
# Conflicts: # dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/CommandMapper.java
SbloodyS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put some pictures in the document. @qingwli
OK, Will update later |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #15978 +/- ##
============================================
- Coverage 40.51% 40.46% -0.06%
+ Complexity 5205 5203 -2
============================================
Files 1379 1379
Lines 46093 46116 +23
Branches 4924 4931 +7
============================================
- Hits 18673 18659 -14
- Misses 25494 25531 +37
Partials 1926 1926 ☔ View full report in Codecov by Sentry. |
|
@SbloodyS Done |
|
Since this is compatible with 3.2.1, so I change the milestone to 3.2.2. |
dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_h2.sql
Outdated
Show resolved
Hide resolved
...ler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataAnalysisController.java
Outdated
Show resolved
Hide resolved
...ler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataAnalysisController.java
Outdated
Show resolved
Hide resolved
...inscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ErrorCommandMapper.java
Outdated
Show resolved
Hide resolved
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/CommandMapper.java
Outdated
Show resolved
Hide resolved
...er-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessDefinitionMapper.xml
Outdated
Show resolved
Hide resolved
...heduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ErrorCommandMapper.xml
Outdated
Show resolved
Hide resolved
...heduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ErrorCommandMapper.xml
Outdated
Show resolved
Hide resolved
…/api/controller/DataAnalysisController.java Co-authored-by: Wenjun Ruan <[email protected]>
…/api/controller/DataAnalysisController.java Co-authored-by: Wenjun Ruan <[email protected]>
…/dao/mapper/ErrorCommandMapper.java Co-authored-by: Wenjun Ruan <[email protected]>
…duler/dao/mapper/ErrorCommandMapper.xml Co-authored-by: Wenjun Ruan <[email protected]>
…/dao/mapper/CommandMapper.java Co-authored-by: Wenjun Ruan <[email protected]>
…duler/dao/mapper/ErrorCommandMapper.xml Co-authored-by: Wenjun Ruan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically LGTM, it would be better if you can add UT.
caishunfeng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
rickchengx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
I will add some UT later |
|
…/project parameters data type (#15967) * [Improvement][parameter] New data types and type filtering * [Improvement][parameter] Improvement startup parameters/global parameters data type * fix api interfaces compatible * add project parameter data type default value * [Improvement][parameter] New data types and type filtering * [Improvement][parameter] Improvement startup parameters/global parameters data type * fix api interfaces compatible * add project parameter data type default value * improvement project code * remove useless imports * remove method onClearSearchTaskType * add parameter doc * optimisation logic * code conflict resolution * code conflict resolution * [Improvement][Monitor] Show master && worker Busy Or Normal Status and Show Commands table list (#15978) * update * test * add monitor enhance ui * update * update * update doc * fix spotless * update * update * Update dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataAnalysisController.java Co-authored-by: Wenjun Ruan <[email protected]> * Update dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataAnalysisController.java Co-authored-by: Wenjun Ruan <[email protected]> * Update dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ErrorCommandMapper.java Co-authored-by: Wenjun Ruan <[email protected]> * Update dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ErrorCommandMapper.xml Co-authored-by: Wenjun Ruan <[email protected]> * Update dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/CommandMapper.java Co-authored-by: Wenjun Ruan <[email protected]> * Update dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ErrorCommandMapper.xml Co-authored-by: Wenjun Ruan <[email protected]> * update * fix spotless * update --------- Co-authored-by: Wenjun Ruan <[email protected]> * [Improvement][Monitor] Add UT for montor (#15998) * formatting Code
…ASF release (#16042) * add version of 3.2.2 * Fix rpc channel leak due to concurrent operation (#16021) * Fix rpc channel leak due to concurrent operation * Throw channel create failed exception --------- Co-authored-by: Rick Cheng <[email protected]> * Fix WorkerTaskExecutorThreadPool#isOverload is incorrect (#16027) * cp: Reduce the size of tarball to continue ASF release (#15004) (#15540) * Reduce the size of tarball to continue ASF release for more detail you can see https://lists.apache.org/thread/rmp7fghlj0n7h9y2v3p8gkw9f9qbo6qt # Conflicts: # tools/dependencies/known-dependencies.txt * Increase block-until-connected in ZookeeperRegistryTestCase (#16041) * [Fix][CI] fix the ci error of Values.datasource.profile (#16031) Co-authored-by: Eric Gao <[email protected]> * Correction of Typos in the Chinese Document Appendix for Task Parameters (#16033) Co-authored-by: Rick Cheng <[email protected]> * [DSIP-39][parameter] Improvement startup parameters/global parameters/project parameters data type (#15967) * [Improvement][parameter] New data types and type filtering * [Improvement][parameter] Improvement startup parameters/global parameters data type * fix api interfaces compatible * add project parameter data type default value * [Improvement][parameter] New data types and type filtering * [Improvement][parameter] Improvement startup parameters/global parameters data type * fix api interfaces compatible * add project parameter data type default value * improvement project code * remove useless imports * remove method onClearSearchTaskType * add parameter doc * optimisation logic * code conflict resolution * code conflict resolution * [Improvement][Monitor] Show master && worker Busy Or Normal Status and Show Commands table list (#15978) * update * test * add monitor enhance ui * update * update * update doc * fix spotless * update * update * Update dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataAnalysisController.java Co-authored-by: Wenjun Ruan <[email protected]> * Update dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataAnalysisController.java Co-authored-by: Wenjun Ruan <[email protected]> * Update dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ErrorCommandMapper.java Co-authored-by: Wenjun Ruan <[email protected]> * Update dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ErrorCommandMapper.xml Co-authored-by: Wenjun Ruan <[email protected]> * Update dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/CommandMapper.java Co-authored-by: Wenjun Ruan <[email protected]> * Update dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ErrorCommandMapper.xml Co-authored-by: Wenjun Ruan <[email protected]> * update * fix spotless * update --------- Co-authored-by: Wenjun Ruan <[email protected]> * [Improvement][Monitor] Add UT for montor (#15998) * formatting Code * add pom * Fix NettyRemotingClient might throw IllegalMonitorStateException (#16038) * Removed unused StateEventHandleFailure (#16052) * Remove OmitStackTraceInFastThrow in start.sh (#16054) * Update Chart.yaml Rollback APPversion * modify log msg (#16062) Co-authored-by: xiangzihao <[email protected]> * [DS-16046][fix] Set PreparedStatement parameter type (#16050) Fix the PreparedStatement parameter is TIME, set it to java.sql.Time Co-authored-by: Aaron Wang <[email protected]> Co-authored-by: Rick Cheng <[email protected]> * Update pom.xml * [DSIP-42] Add dolphinscheduler-aws-authentication module (#16043) --------- Co-authored-by: wangxj <wangxj31> Co-authored-by: Wenjun Ruan <[email protected]> Co-authored-by: Rick Cheng <[email protected]> Co-authored-by: Eric Gao <[email protected]> Co-authored-by: TianXinCoord <[email protected]> Co-authored-by: 小可耐 <[email protected]> Co-authored-by: sleo <[email protected]> Co-authored-by: xiangzihao <[email protected]> Co-authored-by: yinxiaolog <[email protected]> Co-authored-by: Aaron Wang <[email protected]>




Uh oh!
There was an error while loading. Please reload this page.