[Improvement] Fix the git url command injection in pytorch task(#15873) #15950
Conversation
cntigers
requested review from
SbloodyS,
caishunfeng and
zhuangchong
as code owners
cntigers
changed the title
| Assertions.assertFalse(GitProjectManager.isGitPath("git@& cat /etc/passwd >/poc.txt #")); | ||
| Assertions.assertFalse(GitProjectManager.isGitPath("git@| cat /etc/passwd >/poc.txt #")); |
There was a problem hiding this comment.
Please add a positive case which will return true.
There was a problem hiding this comment.
Please add a positive case which will return true.
Thank you for your reminder. I found that there are already positive test cases during testing @ruanwenjun
There was a problem hiding this comment.
Great, please use mvn spotless:apply to format the code style.
There was a problem hiding this comment.
Great, please use
mvn spotless:applyto format the code style.
Thank you for your advice,I have already resolved it.
ruanwenjun
changed the title
ruanwenjun
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #15950 +/- ##
============================================
- Coverage 39.93% 39.86% -0.07%
+ Complexity 5081 5064 -17
============================================
Files 1369 1369
Lines 45635 45635
Branches 4869 4868 -1
============================================
- Hits 18224 18193 -31
- Misses 25513 25544 +31
Partials 1898 1898 ☔ View full report in Codecov by Sentry. |
|
6 participants
Purpose of the pull request
fix: 15873
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md