Skip to content

[Feature-16269][dinky-task]Supports dinky tasks to accept Prepare Params passed within a task or from a previous task #15947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SbloodyS merged 19 commits into from
Jul 4, 2024
Merged

[Feature-16269][dinky-task]Supports dinky tasks to accept Prepare Params passed within a task or from a previous task #15947

SbloodyS merged 19 commits into from
Jul 4, 2024

Conversation

@gaoyan1998
Copy link
Contributor

@gaoyan1998 gaoyan1998 commented May 6, 2024 •
edited
Loading

Purpose of the pull request

Supports dinky tasks to accept variables passed within a task or from a previous task

close #16269

@gaoyan1998 gaoyan1998 changed the title Supports dinky tasks to accept Prepare Params passed within a task or from a previous task [Feature]Supports dinky tasks to accept Prepare Params passed within a task or from a previous task May 6, 2024
@ruanwenjun ruanwenjun added the improvement make more easy to user or prompt friendly label May 6, 2024
@ruanwenjun ruanwenjun added this to the 3.2.2 milestone May 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.15%. Comparing base (565a917) to head (345b2aa).
Report is 4 commits behind head on dev.

❗ Current head 345b2aa differs from pull request most recent head 427a368

Please upload reports for the commit 427a368 to get more accurate results.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev   #15947      +/-   ##
============================================
- Coverage     41.17%   41.15%   -0.03%     
+ Complexity     5093     5091       -2     
============================================
  Files          1391     1391              
  Lines         43803    43803              
  Branches       4645     4645              
============================================
- Hits          18038    18028      -10     
- Misses        23997    24006       +9     
- Partials       1768     1769       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SbloodyS SbloodyS added feature new feature first time contributor First-time contributor miss:docs missing documents in PR 3.2.2 labels May 6, 2024
SbloodyS
SbloodyS reviewed May 6, 2024
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please supplement the document. @gaoyan1998

@gaoyan1998 gaoyan1998 requested a review from EricGao888 as a code owner May 7, 2024 08:05
@gaoyan1998
Copy link
Contributor Author

gaoyan1998 commented May 7, 2024

Please supplement the document. @gaoyan1998

@SbloodyS PTAL, Supplement the documentation done.

@SbloodyS SbloodyS removed the miss:docs missing documents in PR label May 7, 2024
@SbloodyS
Copy link
Member

SbloodyS commented May 8, 2024

Please run mvn spotless:apply to format the code. @gaoyan1998

@gaoyan1998
Copy link
Contributor Author

gaoyan1998 commented May 9, 2024

Please run mvn spotless:apply to format the code. @gaoyan1998

I have resolved it，please review it，thanks. @SbloodyS

@gaoyan1998 gaoyan1998 requested a review from ruanwenjun May 12, 2024 14:22
gaoyan1998 and others added 5 commits May 14, 2024 21:29
@gaoyan1998 @ruanwenjun
fix dinky unresolve params
1d57f6b
@gaoyan1998 @ruanwenjun
Supplement the Dinky documentation
3f39476
@gaoyan1998 @ruanwenjun
formate doc code
11d1fc6
@gaoyan1998 @ruanwenjun
Update dolphinscheduler-task-plugin/dolphinscheduler-task-dinky/src/m…
bae38af 
…ain/java/org/apache/dolphinscheduler/plugin/task/dinky/DinkyTask.java

Co-authored-by: Wenjun Ruan <[email protected]>
@gaoyan1998 @ruanwenjun
Update dolphinscheduler-task-plugin/dolphinscheduler-task-dinky/src/m…
2902943 
…ain/java/org/apache/dolphinscheduler/plugin/task/dinky/DinkyTask.java

Co-authored-by: Wenjun Ruan <[email protected]>
gaoyan1998 added 2 commits May 25, 2024 22:12
@gaoyan1998
Merge remote-tracking branch 'ikiler/fix-dinky-params' into fix-dinky…
30307eb 
…-params

# Conflicts:
#	dolphinscheduler-task-plugin/dolphinscheduler-task-dinky/src/main/java/org/apache/dolphinscheduler/plugin/task/dinky/DinkyTask.java
@gaoyan1998
fix import lost error
7e4ee87
@gaoyan1998
Copy link
Contributor Author

gaoyan1998 commented May 27, 2024

hi @ruanwenjun PTAL ,please approval workflows

@ruanwenjun ruanwenjun added 3.3.0 and removed 3.2.2 labels May 29, 2024
@ruanwenjun ruanwenjun modified the milestones: 3.2.2, 3.3.0 May 29, 2024
ruanwenjun
ruanwenjun approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

SbloodyS
SbloodyS reviewed Jul 2, 2024
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create an issue and link to it. @gaoyan1998

@gaoyan1998 gaoyan1998 changed the title [Feature]Supports dinky tasks to accept Prepare Params passed within a task or from a previous task [Feature-16269][dinky-task]Supports dinky tasks to accept Prepare Params passed within a task or from a previous task Jul 3, 2024
@gaoyan1998
Copy link
Contributor Author

gaoyan1998 commented Jul 3, 2024

Please create an issue and link to it. @gaoyan1998

@SbloodyS Sorry for the missing issue, it has now been created and the title changed

@gaoyan1998 gaoyan1998 requested a review from Gallardot as a code owner July 3, 2024 15:51
SbloodyS
SbloodyS approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
45.8% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

@SbloodyS SbloodyS merged commit 82b501a into apache:dev Jul 4, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 4, 2024

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SbloodyS SbloodyS SbloodyS approved these changes

@ruanwenjun ruanwenjun ruanwenjun approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@zhuangchong zhuangchong Awaiting requested review from zhuangchong

@EricGao888 EricGao888 Awaiting requested review from EricGao888 EricGao888 is a code owner

@Gallardot Gallardot Awaiting requested review from Gallardot Gallardot is a code owner

Assignees

@gaoyan1998 gaoyan1998

Labels

3.3.0 backend document feature new feature first time contributor First-time contributor improvement make more easy to user or prompt friendly priority:high

Projects

None yet

Milestone

3.3.0-alpha

Development

Successfully merging this pull request may close these issues.

[Feature][dinky task] Supports dinky tasks to accept Prepare Params passed within a task or from a previous task

4 participants

@gaoyan1998 @codecov-commenter @SbloodyS @ruanwenjun