-
Notifications
You must be signed in to change notification settings - Fork 5k
Optimizing the scope of RPC base classes #15946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimizing the scope of RPC base classes #15946
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #15946 +/- ##
============================================
- Coverage 39.79% 39.78% -0.02%
+ Complexity 5044 5032 -12
============================================
Files 1353 1354 +1
Lines 45619 45601 -18
Branches 4891 4890 -1
============================================
- Hits 18156 18141 -15
+ Misses 25553 25550 -3
Partials 1910 1910 ☔ View full report in Codecov by Sentry. |
a076303 to
b703c5e
Compare
b703c5e to
090eb18
Compare
rickchengx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9ac5da5 to
5209b2b
Compare
5209b2b to
38acf95
Compare
38acf95 to
ccbb150
Compare
|
Please retry analysis of this Pull-Request directly on SonarCloud |
caishunfeng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md