Skip to content

[TEST] increase coverage of project preference service test #15939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
EricGao888 merged 3 commits into from
Apr 29, 2024
Merged

[TEST] increase coverage of project preference service test #15939

EricGao888 merged 3 commits into from
Apr 29, 2024

Conversation

@abzymeinsjtu
Copy link

@abzymeinsjtu abzymeinsjtu commented Apr 29, 2024

Purpose of the pull request

increase coverage of project preference service test

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.71%. Comparing base (647cbae) to head (1a14664).

❗ Current head 1a14664 differs from pull request most recent head f927faa. Consider uploading reports for the commit f927faa to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev   #15939      +/-   ##
============================================
+ Coverage     39.66%   39.71%   +0.05%     
- Complexity     5016     5022       +6     
============================================
  Files          1353     1353              
  Lines         45637    45637              
  Branches       4892     4892              
============================================
+ Hits          18100    18125      +25     
+ Misses        25622    25601      -21     
+ Partials       1915     1911       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

EricGao888
EricGao888 previously approved these changes Apr 29, 2024
View reviewed changes
@abzymeinsjtu abzymeinsjtu force-pushed the feat_inc_coverage_of_project_related_service branch from 89a4c5a to 41bf0ef Compare April 29, 2024 07:35
Radeity
Radeity approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@Radeity Radeity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abzymeinsjtu abzymeinsjtu requested a review from Radeity April 29, 2024 08:20
@abzymeinsjtu abzymeinsjtu reopened this Apr 29, 2024
@EricGao888
Copy link
Member

EricGao888 commented Apr 29, 2024

LGTM

@Radeity Could u plz help add a ready-to-merge label to this PR? I'm using github ios app and could not add labels without accessing my laptop. Thx

@Radeity Radeity modified the milestones: 3.2.2, 3.3.0 Apr 29, 2024
@Radeity Radeity added 3.3.0 improvement make more easy to user or prompt friendly and removed 3.2.2 labels Apr 29, 2024
@Radeity
Copy link
Member

Radeity commented Apr 29, 2024

@Radeity Could u plz help add a ready-to-merge label to this PR? I'm using github ios app and could not add labels without accessing my laptop. Thx

Done.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@EricGao888 EricGao888 merged commit ebcdaeb into apache:dev Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EricGao888 EricGao888 EricGao888 approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

@Radeity Radeity Awaiting requested review from Radeity

Assignees

@abzymeinsjtu abzymeinsjtu

Labels

3.3.0 backend improvement make more easy to user or prompt friendly ready-to-merge

Projects

None yet

Milestone

3.3.0-alpha

Development

Successfully merging this pull request may close these issues.

5 participants

@abzymeinsjtu @codecov-commenter @EricGao888 @Radeity @abzymeatsjtu