[Improvement-15919][datasource] Improvement datasource get name #15920
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #15920 +/- ##
============================================
+ Coverage 39.66% 39.72% +0.06%
- Complexity 5013 5034 +21
============================================
Files 1349 1349
Lines 45613 45615 +2
Branches 4891 4891
============================================
+ Hits 18091 18122 +31
+ Misses 25607 25578 -29
Partials 1915 1915 ☔ View full report in Codecov by Sentry. |
| @Override | ||
| public String getName() { | ||
| return "athena"; | ||
| return DbType.ATHENA.getDescp(); |
There was a problem hiding this comment.
What about change the descp to identify or name in DbType, since descp means description, this is easy to be changed.
There was a problem hiding this comment.
What about change the descp to
identifyornamein DbType, since descp means description, this is easy to be changed.
I suggest change it to this (DbType.ATHENA.name().toLowerCase()) Or add a field name to the DbType
The descp field I would recommend keeping，What do you recommend?
There was a problem hiding this comment.
You can add new field name or identify in DbType.
There was a problem hiding this comment.
You can add new field
nameoridentifyin DbType.
Modifications completed
|
4 participants
fix #15919
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md