[fix-15907] Fix get remote shell exit code is incorrect #15911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zzih96
requested review from
SbloodyS,
caishunfeng and
zhuangchong
as code owners
ruanwenjun
requested changes
Apr 25, 2024
Member
ruanwenjun
left a comment
ruanwenjun
left a comment
There was a problem hiding this comment.
Please directly use StringUtils
...eshell/src/main/java/org/apache/dolphinscheduler/plugin/task/remoteshell/RemoteExecutor.java
Outdated
Show resolved
Hide resolved
ruanwenjun
changed the title
ruanwenjun
force-pushed
the
fix-status-code
branch
from
0db4f98 to
532a97c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #15911 +/- ##
============================================
- Coverage 39.86% 39.86% -0.01%
+ Complexity 5060 5059 -1
============================================
Files 1369 1369
Lines 45635 45635
Branches 4869 4869
============================================
- Hits 18193 18192 -1
Misses 25544 25544
- Partials 1898 1899 +1 ☔ View full report in Codecov by Sentry. |
…/src/main/java/org/apache/dolphinscheduler/plugin/task/remoteshell/RemoteExecutor.java Co-authored-by: Wenjun Ruan <[email protected]>
ruanwenjun
force-pushed
the
fix-status-code
branch
from
f1d2462 to
eb73f6d
Compare
|
stoplyy
added a commit
to stoplyy/dolphinscheduler
that referenced
this pull request
Sep 14, 2024
Contributor
|
It seems a new bug has been introduced. The .trim() in the original code is necessary, otherwise the case of xxx-0\n cannot be handled.
|
Contributor
such is the case |
Member
stoplyy
pushed a commit
to stoplyy/dolphinscheduler
that referenced
this pull request
Jun 12, 2025
* ./mvnw spotless:apply * Update dolphinscheduler-task-plugin/dolphinscheduler-task-remoteshell/src/main/java/org/apache/dolphinscheduler/plugin/task/remoteshell/RemoteExecutor.java Co-authored-by: Wenjun Ruan <[email protected]> --------- Co-authored-by: 詹子恒 <[email protected]> Co-authored-by: Wenjun Ruan <[email protected]> Co-authored-by: Rick Cheng <[email protected]>
stoplyy
pushed a commit
to stoplyy/dolphinscheduler
that referenced
this pull request
Jun 12, 2025
* ./mvnw spotless:apply * Update dolphinscheduler-task-plugin/dolphinscheduler-task-remoteshell/src/main/java/org/apache/dolphinscheduler/plugin/task/remoteshell/RemoteExecutor.java Co-authored-by: Wenjun Ruan <[email protected]> --------- Co-authored-by: 詹子恒 <[email protected]> Co-authored-by: Wenjun Ruan <[email protected]> Co-authored-by: Rick Cheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
fix #15907
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md