Skip to content

Fix jar path is not correct in java task #15906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
caishunfeng merged 1 commit into from
Apr 29, 2024
Merged

Fix jar path is not correct in java task #15906

caishunfeng merged 1 commit into from
Apr 29, 2024

Conversation

@ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Apr 25, 2024

Purpose of the pull request

close #15902

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun self-assigned this Apr 25, 2024
@ruanwenjun ruanwenjun mentioned this pull request Apr 25, 2024
Closed
3 tasks
@ruanwenjun ruanwenjun added the bug Something isn't working label Apr 25, 2024
@ruanwenjun ruanwenjun added this to the 3.2.2 milestone Apr 25, 2024
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixJavaTaskPath branch from 6af0638 to 6059341 Compare April 25, 2024 03:10
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.74%. Comparing base (647cbae) to head (f6366d5).

❗ Current head f6366d5 differs from pull request most recent head 9d95b18. Consider uploading reports for the commit 9d95b18 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev   #15906      +/-   ##
============================================
+ Coverage     39.66%   39.74%   +0.07%     
- Complexity     5016     5037      +21     
============================================
  Files          1353     1353              
  Lines         45637    45619      -18     
  Branches       4892     4891       -1     
============================================
+ Hits          18100    18129      +29     
+ Misses        25622    25575      -47     
  Partials       1915     1915

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixJavaTaskPath branch from 6059341 to 2bcb524 Compare April 25, 2024 11:07
Radeity
Radeity previously approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@Radeity Radeity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixJavaTaskPath branch 2 times, most recently from 28b1dbb to ffff286 Compare April 28, 2024 07:47
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixJavaTaskPath branch from ffff286 to 86e5b9c Compare April 28, 2024 07:51
@ruanwenjun ruanwenjun requested a review from Radeity April 28, 2024 07:52
caishunfeng
caishunfeng previously approved these changes Apr 28, 2024
View reviewed changes
Radeity
Radeity previously approved these changes Apr 28, 2024
View reviewed changes
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixJavaTaskPath branch from 86e5b9c to 6075f2c Compare April 28, 2024 08:11
@ruanwenjun ruanwenjun dismissed stale reviews from Radeity and caishunfeng via 41f5d6c April 28, 2024 08:50
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixJavaTaskPath branch 2 times, most recently from 41f5d6c to 4926250 Compare April 28, 2024 08:53
Radeity
Radeity approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@Radeity Radeity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Radeity
Copy link
Member

Radeity commented Apr 29, 2024

Some humble suggestion, next time, can you add additional explanations for the modifications made after PR is approved when performing a force-push?

@ruanwenjun
Copy link
Member Author

ruanwenjun commented Apr 29, 2024

Some humble suggestion, next time, can you add additional explanations for the modifications made after PR is approved when performing a force-push?

Thanks for your suggestion, I will add message next time, I'm just worried that these won't be cleaned up in the merger.

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixJavaTaskPath branch from 4926250 to 9d95b18 Compare April 29, 2024 08:17
@Radeity
Copy link
Member

Radeity commented Apr 29, 2024

Some humble suggestion, next time, can you add additional explanations for the modifications made after PR is approved when performing a force-push?

Thanks for your suggestion, I will add message next time, I'm just worried that these won't be cleaned up in the merger.

Yeah, I can get your point, keep one commit is cleaner. With additional message, review the PR again will be faster :D

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

caishunfeng
caishunfeng approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng merged commit 0a11cd2 into apache:dev Apr 29, 2024
@ruanwenjun ruanwenjun deleted the dev_wenjun_fixJavaTaskPath branch April 29, 2024 11:19
This was referenced Jun 28, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caishunfeng caishunfeng caishunfeng approved these changes

@Radeity Radeity Radeity approved these changes

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

@zhuangchong zhuangchong Awaiting requested review from zhuangchong

Assignees

@ruanwenjun ruanwenjun

Labels

backend bug Something isn't working priority:high ready-to-merge

Projects

None yet

Milestone

3.2.2

Development

Successfully merging this pull request may close these issues.

[Bug] [JAVA TASK] Unable to access jarfile

4 participants

@ruanwenjun @codecov-commenter @Radeity @caishunfeng