Skip to content

Use workerNodeInfoWriteLock to update work node info #15903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Radeity merged 2 commits into from
Apr 26, 2024
Merged

Use workerNodeInfoWriteLock to update work node info #15903

Radeity merged 2 commits into from
Apr 26, 2024

Conversation

@DaqianLiao
Copy link
Contributor

@DaqianLiao DaqianLiao commented Apr 24, 2024 •
edited by SbloodyS
Loading

… be used. close #15898

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@Radeity Radeity added this to the 3.2.2 milestone Apr 24, 2024
@Radeity Radeity added the bug Something isn't working label Apr 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.72%. Comparing base (b3b8c07) to head (a26a7b7).

❗ Current head a26a7b7 differs from pull request most recent head 811421d. Consider uploading reports for the commit 811421d to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##                dev   #15903   +/-   ##
=========================================
  Coverage     39.72%   39.72%           
  Complexity     5034     5034           
=========================================
  Files          1349     1349           
  Lines         45615    45615           
  Branches       4892     4892           
=========================================
  Hits          18122    18122           
  Misses        25578    25578           
  Partials       1915     1915

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apache apache deleted a comment from DaqianLiao Apr 25, 2024
@SbloodyS SbloodyS added first time contributor First-time contributor 3.2.2 labels Apr 25, 2024
ruanwenjun
ruanwenjun approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ruanwenjun ruanwenjun changed the title [Fix] In updateWorkerNodes method, the workerNodeInfoWriteLock should be used. #15898 [Fix] Use workerGroupWriteLock to update work node info Apr 25, 2024
@ruanwenjun ruanwenjun added improvement make more easy to user or prompt friendly and removed bug Something isn't working labels Apr 25, 2024
@ruanwenjun ruanwenjun changed the title [Fix] Use workerGroupWriteLock to update work node info Use workerGroupWriteLock to update work node info Apr 25, 2024
@ruanwenjun ruanwenjun changed the title Use workerGroupWriteLock to update work node info Use workerNodeInfoWriteLock to update work node info Apr 25, 2024
@ruanwenjun
Copy link
Member

ruanwenjun commented Apr 25, 2024

I change this to improvement, and remove the bug label, since this will not cause a bug

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Radeity Radeity merged commit b29965b into apache:dev Apr 26, 2024
@Radeity
Copy link
Member

Radeity commented Apr 26, 2024

I change this to improvement, and remove the bug label, since this will not cause a bug

Oops, my mistake, forgot to update commit message, will pay more attention next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruanwenjun ruanwenjun ruanwenjun approved these changes

@Radeity Radeity Radeity approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

Assignees

@DaqianLiao DaqianLiao

Labels

3.2.2 backend first time contributor First-time contributor improvement make more easy to user or prompt friendly ready-to-merge

Projects

None yet

Milestone

3.2.2

Development

Successfully merging this pull request may close these issues.

[Bug] [Master] Use workerGroupWriteLock to update work node info

5 participants

@DaqianLiao @codecov-commenter @ruanwenjun @Radeity @SbloodyS