Fix kill dynamic task doesn't kill the wait to run workflow instances #15896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #15896 +/- ##
============================================
- Coverage 39.78% 39.66% -0.13%
+ Complexity 5038 5013 -25
============================================
Files 1349 1349
Lines 45580 45615 +35
Branches 4890 4892 +2
============================================
- Hits 18132 18091 -41
- Misses 25532 25609 +77
+ Partials 1916 1915 -1 ☔ View full report in Codecov by Sentry. |
ruanwenjun
force-pushed
the
dev_wenjun_fixKillDynamicTask
branch
from
1da289f to
8bc89bd
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
When we kill a DynamicTask, the commands should be deleted, and wait to run sub workflow instance should be kill.
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md