Skip to content

[Improvement] Fix alert code smell #15892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
qingwli merged 1 commit into from
Apr 23, 2024
Merged

[Improvement] Fix alert code smell #15892

qingwli merged 1 commit into from
Apr 23, 2024

Conversation

@qingwli
Copy link
Member

@qingwli qingwli commented Apr 23, 2024

No description provided.

@qingwli qingwli added the improvement make more easy to user or prompt friendly label Apr 23, 2024
@qingwli qingwli self-assigned this Apr 23, 2024
@qingwli qingwli requested a review from caishunfeng as a code owner April 23, 2024 06:17
@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 39.63%. Comparing base (e9d8591) to head (4926923).

❗ Current head 4926923 differs from pull request most recent head df327d8. Consider uploading reports for the commit df327d8 to get more accurate results

Files Patch % Lines
...cheduler/plugin/alert/dingtalk/DingTalkSender.java 0.00% 4 Missing ⚠️
...olphinscheduler/plugin/alert/email/MailSender.java 33.33% 2 Missing ⚠️
...dolphinscheduler/plugin/alert/http/HttpSender.java 50.00% 2 Missing ⚠️
...lphinscheduler/plugin/alert/slack/SlackSender.java 0.00% 2 Missing ⚠️
...hinscheduler/plugin/alert/wechat/WeChatSender.java 33.33% 2 Missing ⚠️
...hinscheduler/plugin/alert/feishu/FeiShuSender.java 0.00% 1 Missing ⚠️
...plugin/alert/prometheus/PrometheusAlertSender.java 0.00% 1 Missing ⚠️
...pache/dolphinscheduler/common/utils/HttpUtils.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                dev   #15892      +/-   ##
============================================
- Coverage     39.64%   39.63%   -0.02%     
+ Complexity     5023     5019       -4     
============================================
  Files          1349     1349              
  Lines         45593    45583      -10     
  Branches       4890     4890              
============================================
- Hits          18074    18065       -9     
  Misses        25596    25596              
+ Partials       1923     1922       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 23, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Gallardot
Gallardot approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@Gallardot Gallardot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ruanwenjun
ruanwenjun approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun added ready-to-merge minor Chore Chores about the project, like code clean, typo, etc. labels Apr 23, 2024
@ruanwenjun ruanwenjun added this to the 3.2.2 milestone Apr 23, 2024
@qingwli qingwli merged commit 59f060e into apache:dev Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gallardot Gallardot Gallardot approved these changes

@ruanwenjun ruanwenjun ruanwenjun approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng

Assignees

@qingwli qingwli

Labels

backend improvement make more easy to user or prompt friendly minor Chore Chores about the project, like code clean, typo, etc. ready-to-merge

Projects

None yet

Milestone

3.2.2

Development

Successfully merging this pull request may close these issues.

4 participants

@qingwli @codecov-commenter @Gallardot @ruanwenjun