Skip to content

Conversation

@ruanwenjun
Copy link
Member

Purpose of the pull request

close #15889

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.61%. Comparing base (6c78c8e) to head (72ebf16).

❗ Current head 72ebf16 differs from pull request most recent head d1a9d83. Consider uploading reports for the commit d1a9d83 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15890      +/-   ##
============================================
- Coverage     39.61%   39.61%   -0.01%     
- Complexity     5016     5019       +3     
============================================
  Files          1349     1349              
  Lines         45584    45584              
  Branches       4888     4887       -1     
============================================
- Hits          18059    18058       -1     
  Misses        25605    25605              
- Partials       1920     1921       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanwenjun ruanwenjun added DSIP improvement make more easy to user or prompt friendly labels Apr 22, 2024
@ruanwenjun ruanwenjun added this to the 3.2.2 milestone Apr 22, 2024
Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ruanwenjun ruanwenjun changed the title [DSIP-31] Reduce the thread pool size of hikari [DSIP-31] Reduce the connection pool size of hikari Apr 22, 2024
@ruanwenjun ruanwenjun merged commit e2c8b08 into apache:dev Apr 22, 2024
@ruanwenjun ruanwenjun deleted the dev_wenjun_fix15889 branch April 22, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend DSIP improvement make more easy to user or prompt friendly ready-to-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DSIP-31] Reduce the connection pool size of hikari

5 participants