Skip to content

Conversation

@ruanwenjun
Copy link
Member

Purpose of the pull request

fix #15864

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 39.55%. Comparing base (e2c8b08) to head (083475a).

❗ Current head 083475a differs from pull request most recent head d8c25e4. Consider uploading reports for the commit d8c25e4 to get more accurate results

Files Patch % Lines
...er/service/process/TriggerRelationServiceImpl.java 76.47% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15883      +/-   ##
============================================
- Coverage     39.61%   39.55%   -0.07%     
+ Complexity     5016     4998      -18     
============================================
  Files          1349     1349              
  Lines         45584    45593       +9     
  Branches       4888     4890       +2     
============================================
- Hits          18059    18033      -26     
- Misses        25605    25638      +33     
- Partials       1920     1922       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixTriggerRelation branch from 94b3d93 to d8c25e4 Compare April 22, 2024 09:05
@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarCloud

@sonarqubecloud
Copy link

@ruanwenjun ruanwenjun merged commit e9d8591 into apache:dev Apr 22, 2024
@ruanwenjun ruanwenjun deleted the dev_wenjun_fixTriggerRelation branch April 22, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][Master] Transform command to WorkflowExecutionRunnable failed due to t_ds_trigger_relation duplicate data

3 participants