Skip to content

Conversation

@ruanwenjun
Copy link
Member

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun requested a review from SbloodyS as a code owner April 18, 2024 05:37
@github-actions github-actions bot added the CI&CD label Apr 18, 2024
@ruanwenjun ruanwenjun added the improvement make more easy to user or prompt friendly label Apr 18, 2024
@ruanwenjun ruanwenjun added this to the 3.2.2 milestone Apr 18, 2024
@ruanwenjun ruanwenjun self-assigned this Apr 18, 2024
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addDSIPTemplate branch 2 times, most recently from 5448f08 to feacfaa Compare April 18, 2024 05:40
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.30%. Comparing base (a8bc237) to head (f970860).

❗ Current head f970860 differs from pull request most recent head ac4e184. Consider uploading reports for the commit ac4e184 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15871      +/-   ##
============================================
- Coverage     39.37%   39.30%   -0.07%     
+ Complexity     4972     4947      -25     
============================================
  Files          1347     1347              
  Lines         45630    45630              
  Branches       4890     4891       +1     
============================================
- Hits          17968    17937      -31     
- Misses        25747    25778      +31     
  Partials       1915     1915              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addDSIPTemplate branch from ac4e184 to 5e25539 Compare April 18, 2024 07:44
@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarCloud

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit 8fc2049 into apache:dev Apr 18, 2024
@ruanwenjun ruanwenjun deleted the dev_wenjun_addDSIPTemplate branch April 18, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.2.2 chore CI&CD improvement make more easy to user or prompt friendly ready-to-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants