[Fix-15706] Seatunnel improvement #15852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinxingi
requested review from
SbloodyS,
caishunfeng and
zhuangchong
as code owners
SbloodyS
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #15852 +/- ##
============================================
- Coverage 39.57% 39.57% -0.01%
Complexity 5010 5010
============================================
Files 1347 1347
Lines 45629 45631 +2
Branches 4890 4891 +1
============================================
Hits 18057 18057
- Misses 25648 25650 +2
Partials 1924 1924 ☔ View full report in Codecov by Sentry. |
rickchengx
reviewed
Apr 16, 2024
...seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/SeatunnelTask.java
Outdated
Show resolved
Hide resolved
SbloodyS
reviewed
Apr 16, 2024
...seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/SeatunnelTask.java
Outdated
Show resolved
Hide resolved
… into fix_seatunnel_15706_Improvement
qingwli
reviewed
Apr 16, 2024
...seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/SeatunnelTask.java
Outdated
Show resolved
Hide resolved
qingwli
reviewed
Apr 16, 2024
...unnel/src/main/test/org/apache/dolphinscheduler/plugin/task/seatunnel/SeatunnelTaskTest.java
Outdated
Show resolved
Hide resolved
...unnel/src/main/test/org/apache/dolphinscheduler/plugin/task/seatunnel/SeatunnelTaskTest.java
Outdated
Show resolved
Hide resolved
...unnel/src/main/test/org/apache/dolphinscheduler/plugin/task/seatunnel/SeatunnelTaskTest.java
Outdated
Show resolved
Hide resolved
...unnel/src/main/test/org/apache/dolphinscheduler/plugin/task/seatunnel/SeatunnelTaskTest.java
Show resolved
Hide resolved
caishunfeng
reviewed
Apr 16, 2024
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
fix #15706
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md