[TEST] increase coverage of environment service #15840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricGao888
previously approved these changes
Apr 14, 2024
EricGao888
previously approved these changes
Apr 14, 2024
abzymeinsjtu
force-pushed
the
feat_inc_environment_service_coverage
branch
from
3bf8a3c to
5ac23cd
Compare
abzymeinsjtu
force-pushed
the
feat_inc_environment_service_coverage
branch
from
5ac23cd to
60f1307
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #15840 +/- ##
============================================
+ Coverage 39.47% 39.54% +0.07%
- Complexity 5006 5015 +9
============================================
Files 1347 1347
Lines 45641 45641
Branches 4892 4892
============================================
+ Hits 18017 18050 +33
+ Misses 25691 25668 -23
+ Partials 1933 1923 -10 ☔ View full report in Codecov by Sentry. |
qingwli
requested changes
Apr 15, 2024
Member
qingwli
left a comment
qingwli
left a comment
There was a problem hiding this comment.
Please fix code smell
assertEquals(
((List<Environment>) result.get(Constants.DATA_LIST)).size(), 0);
Swap these 2 arguments so they are in the correct order: expected value, actual value.
abzymeinsjtu
force-pushed
the
feat_inc_environment_service_coverage
branch
from
60f1307 to
4b96ee6
Compare
Author
done |
EricGao888
approved these changes
Apr 15, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
increase coverage of environment service