[DSIP-25][Remote Logging] Split remote logging configuration #15826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickchengx
reviewed
Apr 11, 2024
dolphinscheduler-common/src/main/resources/remote-logging.properties
Outdated
Show resolved
Hide resolved
pegasas
force-pushed
the
issues/15774
branch
5 times, most recently
from
9ad1799 to
1f20762
Compare
pegasas
force-pushed
the
issues/15774
branch
2 times, most recently
from
26e86bb to
06561b8
Compare
ruanwenjun
requested changes
Apr 15, 2024
Member
ruanwenjun
left a comment
ruanwenjun
left a comment
There was a problem hiding this comment.
You should only need to add implementation ImmutablePriorityYamlDelegate and ImmutableYamlDelegate
...mmon/src/main/java/org/apache/dolphinscheduler/common/log/remote/RemoteLogConfiguration.java
Outdated
Show resolved
Hide resolved
...nscheduler-common/src/main/java/org/apache/dolphinscheduler/common/config/IYamlDelegate.java
Outdated
Show resolved
Hide resolved
...er-common/src/main/java/org/apache/dolphinscheduler/common/config/ImmutableYamlDelegate.java
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...nscheduler-common/src/main/java/org/apache/dolphinscheduler/common/config/IYamlDelegate.java
Fixed
Show fixed
Hide fixed
...nscheduler-common/src/main/java/org/apache/dolphinscheduler/common/config/IYamlDelegate.java
Fixed
Show fixed
Hide fixed
...nscheduler-common/src/main/java/org/apache/dolphinscheduler/common/config/IYamlDelegate.java
Fixed
Show fixed
Hide fixed
...nscheduler-common/src/main/java/org/apache/dolphinscheduler/common/config/IYamlDelegate.java
Fixed
Show fixed
Hide fixed
...nscheduler-common/src/main/java/org/apache/dolphinscheduler/common/config/IYamlDelegate.java
Fixed
Show fixed
Hide fixed
...nscheduler-common/src/main/java/org/apache/dolphinscheduler/common/config/IYamlDelegate.java
Fixed
Show fixed
Hide fixed
...nscheduler-common/src/main/java/org/apache/dolphinscheduler/common/config/IYamlDelegate.java
Fixed
Show fixed
Hide fixed
...er-common/src/main/java/org/apache/dolphinscheduler/common/config/ImmutableYamlDelegate.java
Fixed
Show fixed
Hide fixed
ruanwenjun
reviewed
Apr 22, 2024
...er-common/src/main/java/org/apache/dolphinscheduler/common/config/ImmutableYamlDelegate.java
Outdated
Show resolved
Hide resolved
...er-common/src/main/java/org/apache/dolphinscheduler/common/config/ImmutableYamlDelegate.java
Fixed
Show fixed
Hide fixed
pegasas
force-pushed
the
issues/15774
branch
3 times, most recently
from
9311046 to
6d7036f
Compare
ruanwenjun
force-pushed
the
issues/15774
branch
from
6d7036f to
c723337
Compare
...er-common/src/main/java/org/apache/dolphinscheduler/common/config/ImmutableYamlDelegate.java
Fixed
Show fixed
Hide fixed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #15826 +/- ##
============================================
- Coverage 39.89% 39.81% -0.08%
+ Complexity 5057 5038 -19
============================================
Files 1353 1354 +1
Lines 45621 45659 +38
Branches 4891 4894 +3
============================================
- Hits 18199 18181 -18
- Misses 25516 25572 +56
Partials 1906 1906 ☔ View full report in Codecov by Sentry. |
|
Please retry analysis of this Pull-Request directly on SonarCloud |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
resolve: #15774
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md