Skip to content

Conversation

@SbloodyS
Copy link
Member

@SbloodyS SbloodyS commented Mar 18, 2024

Purpose of the pull request

Fix ui build error in #15681 (comment)

@github-actions github-actions bot added the UI ui and front end related label Mar 18, 2024
@SbloodyS SbloodyS marked this pull request as ready for review March 18, 2024 09:02
@SbloodyS SbloodyS self-assigned this Mar 18, 2024
@SbloodyS SbloodyS added 3.2.2 bug Something isn't working chore labels Mar 18, 2024
@SbloodyS SbloodyS added this to the 3.2.2 milestone Mar 18, 2024
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we have so many style only change here? I think we should avoid it, is there any dependence upgrade in recent day?

@zhongjiajie
Copy link
Member

Ok, I got it, we merge some incorrect format code to our codebase before

@zhongjiajie
Copy link
Member

seems bot mergeable not working right now 😕

@SbloodyS SbloodyS merged commit faa794c into apache:dev Mar 18, 2024
@SbloodyS SbloodyS deleted the fix_ui_build_error branch March 18, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.2.2 bug Something isn't working chore ready-to-merge UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants