Skip to content

[Improvement-15725][UI] The default option of project preferences can be clearable. #15727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
calvinjiang merged 4 commits into from
Mar 16, 2024
Merged

[Improvement-15725][UI] The default option of project preferences can be clearable. #15727

calvinjiang merged 4 commits into from
Mar 16, 2024

Conversation

@calvinjiang
Copy link
Contributor

@calvinjiang calvinjiang commented Mar 16, 2024

Purpose of the pull request

This PR will close #15725 .

Brief change log

Verify this pull request

This change added tests and can be verified as follows:

  • Manually verified the change by testing locally.

@github-actions github-actions bot added the UI ui and front end related label Mar 16, 2024
@calvinjiang calvinjiang requested a review from zhuangchong March 16, 2024 07:07
@calvinjiang calvinjiang added improvement make more easy to user or prompt friendly ready-to-merge 3.2.2 labels Mar 16, 2024
@calvinjiang calvinjiang added this to the 3.2.2 milestone Mar 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.07%. Comparing base (832826e) to head (55cd977).

❗ Current head 55cd977 differs from pull request most recent head de39089. Consider uploading reports for the commit de39089 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev   #15727      +/-   ##
============================================
- Coverage     39.07%   39.07%   -0.01%     
  Complexity     4849     4849              
============================================
  Files          1316     1316              
  Lines         45014    45014              
  Branches       4819     4819              
============================================
- Hits          17589    17588       -1     
- Misses        25517    25518       +1     
  Partials       1908     1908

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 16, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@calvinjiang calvinjiang merged commit d49dbba into apache:dev Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhuangchong zhuangchong zhuangchong approved these changes

@songjianet songjianet Awaiting requested review from songjianet songjianet is a code owner

@Amy0104 Amy0104 Awaiting requested review from Amy0104

Assignees

No one assigned

Labels

3.2.2 improvement make more easy to user or prompt friendly ready-to-merge UI ui and front end related

Projects

None yet

Milestone

3.2.2

Development

Successfully merging this pull request may close these issues.

[Improvement][UI] The default option of project preferences can't be canceled.

3 participants

@calvinjiang @codecov-commenter @zhuangchong