Skip to content

[Improvement-15723][UI] Work out the issue that project preferences doesn't replace all places that they need to affect. #15724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhuangchong merged 1 commit into from
Mar 16, 2024
Merged

[Improvement-15723][UI] Work out the issue that project preferences doesn't replace all places that they need to affect. #15724

zhuangchong merged 1 commit into from
Mar 16, 2024

Conversation

@calvinjiang
Copy link
Contributor

@calvinjiang calvinjiang commented Mar 16, 2024

Purpose of the pull request

This PR will close #15723 .

Brief change log

Verify this pull request

This change added tests and can be verified as follows:

  • Manually verified the change by testing locally.

The test results is as follows:

image

@calvinjiang calvinjiang added UI ui and front end related ready-to-merge 3.2.2 labels Mar 16, 2024
@calvinjiang calvinjiang added this to the 3.2.2 milestone Mar 16, 2024
@calvinjiang calvinjiang added improvement make more easy to user or prompt friendly ready-to-merge labels Mar 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.07%. Comparing base (e97f6a4) to head (ea7e254).

❗ Current head ea7e254 differs from pull request most recent head fd2d477. Consider uploading reports for the commit fd2d477 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev   #15724      +/-   ##
============================================
- Coverage     39.09%   39.07%   -0.03%     
+ Complexity     4853     4848       -5     
============================================
  Files          1316     1316              
  Lines         45014    45014              
  Branches       4819     4819              
============================================
- Hits          17599    17588      -11     
- Misses        25506    25517      +11     
  Partials       1909     1909

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@calvinjiang calvinjiang requested a review from zhuangchong March 16, 2024 05:34
@zhuangchong zhuangchong merged commit 832826e into apache:dev Mar 16, 2024
@devosend devosend mentioned this pull request Mar 18, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhuangchong zhuangchong zhuangchong approved these changes

@songjianet songjianet Awaiting requested review from songjianet songjianet is a code owner

@Amy0104 Amy0104 Awaiting requested review from Amy0104

Assignees

No one assigned

Labels

improvement make more easy to user or prompt friendly ready-to-merge UI ui and front end related

Projects

None yet

Milestone

3.2.2

Development

Successfully merging this pull request may close these issues.

[Improvement][UI] Work out the issue that project preferences doesn't replace all places that they need to affect.

3 participants

@calvinjiang @codecov-commenter @zhuangchong