[Improvement-15713][api]DataSource And UdfFunc list query use Enum code value rather than ordinal #15714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickchengx
reviewed
Mar 15, 2024
Contributor
rickchengx
left a comment
rickchengx
left a comment
There was a problem hiding this comment.
@songwenyong please link this PR to an issue
This was referenced Mar 15, 2024
Closed
Contributor
Author
done |
SbloodyS
added
improvement
rickchengx
reviewed
Mar 18, 2024
| public Result<Object> queryDataSourceList(@Parameter(hidden = true) @RequestAttribute(value = Constants.SESSION_USER) User loginUser, | ||
| @RequestParam("type") DbType type) { | ||
| List<DataSource> datasourceList = dataSourceService.queryDataSourceList(loginUser, type.ordinal()); | ||
| List<DataSource> datasourceList = dataSourceService.queryDataSourceList(loginUser, type.getCode()); |
Contributor
There was a problem hiding this comment.
overall LGTM, please update the related UT
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #15714 +/- ##
=========================================
Coverage 39.20% 39.20%
Complexity 4909 4909
=========================================
Files 1326 1326
Lines 45217 45217
Branches 4818 4818
=========================================
Hits 17729 17729
Misses 25617 25617
Partials 1871 1871 ☔ View full report in Codecov by Sentry. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
fix #15713
Brief change log
DataSource list query use DbType enum code value rather than ordinal
UdfFunc list query use UdfType code value rather than ordinal
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md