Skip to content

[Improvement-15707][Master] Work out the issue that the workflow with a task dependency couldn't work well. #15712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhuangchong merged 4 commits into from
Mar 14, 2024
Merged

[Improvement-15707][Master] Work out the issue that the workflow with a task dependency couldn't work well. #15712

zhuangchong merged 4 commits into from
Mar 14, 2024

Conversation

@calvinjiang
Copy link
Contributor

@calvinjiang calvinjiang commented Mar 14, 2024 •
edited
Loading

Purpose of the pull request

This PR will close #15707 .

Brief change log

Verify this pull request

This change added tests and can be verified as follows:

  • Manually verified the change by testing locally.

@github-actions github-actions bot added UI ui and front end related backend labels Mar 14, 2024
@calvinjiang calvinjiang requested a review from zhuangchong March 14, 2024 06:06
@calvinjiang calvinjiang added this to the 3.2.2 milestone Mar 14, 2024
@calvinjiang calvinjiang added improvement make more easy to user or prompt friendly and removed UI ui and front end related labels Mar 14, 2024
@github-actions github-actions bot added the UI ui and front end related label Mar 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 39.05%. Comparing base (738da1c) to head (5ddbf11).

❗ Current head 5ddbf11 differs from pull request most recent head f460e23. Consider uploading reports for the commit f460e23 to get more accurate results

Files Patch % Lines
...cheduler/server/master/utils/DependentExecute.java 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                dev   #15712      +/-   ##
============================================
- Coverage     39.05%   39.05%   -0.01%     
  Complexity     4845     4845              
============================================
  Files          1316     1316              
  Lines         45011    45012       +1     
  Branches       4818     4818              
============================================
  Hits          17581    17581              
- Misses        25524    25525       +1     
  Partials       1906     1906

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot removed the UI ui and front end related label Mar 14, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

zhuangchong
zhuangchong approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@zhuangchong zhuangchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zhuangchong zhuangchong merged commit eab71f1 into apache:dev Mar 14, 2024
@EricGao888 EricGao888 mentioned this pull request Apr 2, 2024
Merged
@starrysxy starrysxy mentioned this pull request Aug 16, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhuangchong zhuangchong zhuangchong approved these changes

@songjianet songjianet Awaiting requested review from songjianet

@Amy0104 Amy0104 Awaiting requested review from Amy0104

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

@ruanwenjun ruanwenjun Awaiting requested review from ruanwenjun ruanwenjun is a code owner

Assignees

No one assigned

Labels

3.2.2 backend improvement make more easy to user or prompt friendly ready-to-merge

Projects

None yet

Milestone

3.2.2

Development

Successfully merging this pull request may close these issues.

[Improvement][Master] Work out the issue that the workflow with a task dependency couldn't work well.

3 participants

@calvinjiang @codecov-commenter @zhuangchong