[Fix][Master] Fix Potential danger in the event of a worker failover #15689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhongJinHacker
requested review from
SbloodyS,
caishunfeng and
ruanwenjun
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #15689 +/- ##
=========================================
Coverage 38.96% 38.96%
Complexity 4840 4840
=========================================
Files 1316 1316
Lines 45010 45011 +1
Branches 4818 4818
=========================================
+ Hits 17539 17540 +1
Misses 25575 25575
Partials 1896 1896 ☔ View full report in Codecov by Sentry. |
SbloodyS
requested changes
Mar 11, 2024
Member
SbloodyS
left a comment
SbloodyS
left a comment
There was a problem hiding this comment.
Please use English in commit message.
Co-authored-by: caishunfeng <[email protected]>
Contributor
Author
fixed |
|
SbloodyS
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
This pull request to fix #15688 , when path is null or empty, it will cause serverhost is null, it is danger
please check the issue out for details
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md