[Bug] fix UT test #15684
Merged
[Bug] fix UT test #15684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SbloodyS
approved these changes
Mar 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #15684 +/- ##
============================================
- Coverage 38.97% 38.96% -0.01%
Complexity 4839 4839
============================================
Files 1316 1316
Lines 45000 45000
Branches 4817 4817
============================================
- Hits 17539 17536 -3
- Misses 25565 25568 +3
Partials 1896 1896 ☔ View full report in Codecov by Sentry. |
|
Please retry analysis of this Pull-Request directly on SonarCloud |
ZhongJinHacker
pushed a commit
to ZhongJinHacker/dolphinscheduler
that referenced
this pull request
Mar 11, 2024
SbloodyS
pushed a commit
that referenced
this pull request
Mar 11, 2024
…15689) * clean unused import * fix style check * fix when path is null or empty, it will cause serverhost is null, * fix UT test (#15684) * [Fix-15639] parameterPassing is null case NPE (#15678) Co-authored-by: caishunfeng <[email protected]> * fix when path is null or empty, it will cause serverhost is null,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
fix UT test false becase different locale.
Brief change log
ResourcesServiceTestVerify this pull request