Skip to content

Conversation

@zero-element
Copy link
Contributor

Purpose of the pull request

fix #15669

Brief change log

add '-m' flag to 'useradd'

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@SbloodyS SbloodyS added bug Something isn't working first time contributor First-time contributor 3.2.2 labels Mar 5, 2024
@SbloodyS SbloodyS added this to the 3.2.2 milestone Mar 5, 2024
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passed.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 38.61%. Comparing base (04a6b0d) to head (b90c400).

❗ Current head b90c400 differs from pull request most recent head 8fe20d9. Consider uploading reports for the commit 8fe20d9 to get more accurate results

Files Patch % Lines
.../apache/dolphinscheduler/common/utils/OSUtils.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15670      +/-   ##
============================================
- Coverage     38.63%   38.61%   -0.03%     
  Complexity     4795     4795              
============================================
  Files          1316     1316              
  Lines         44969    44969              
  Branches       4817     4816       -1     
============================================
- Hits          17373    17363      -10     
- Misses        25713    25724      +11     
+ Partials       1883     1882       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 5, 2024

@SbloodyS SbloodyS merged commit 82ffdbf into apache:dev Mar 5, 2024
@Smilewh888
Copy link

Should I use dev code now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.2.2 backend bug Something isn't working first time contributor First-time contributor ready-to-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [worker] Worker's automatic user creation on linux is not fully correct

4 participants